git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Emily Shaffer <emilyshaffer@google.com>,
	Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Subject: Re: [PATCH] Revert "contrib: subtree: adjust test to change in fmt-merge-msg"
Date: Tue, 4 Aug 2020 09:12:28 -0400	[thread overview]
Message-ID: <5cb1c0f8-53c4-f7c5-d1aa-a9241c511fd0@gmail.com> (raw)
In-Reply-To: <20200803223945.GF2965447@google.com>

On 8/3/2020 6:39 PM, Emily Shaffer wrote:
> On Mon, Aug 03, 2020 at 12:43:25PM -0700, Junio C Hamano wrote:
>>
>> Emily Shaffer <emilyshaffer@google.com> writes:
>> I wonder if it makes more sense to move this (or other tests in
>> contrib/ if any) in the normal test suite so that we'd notice its
>> breakage, though.
> 
> I'd welcome that change. We have some scripted step during our release
> process to run those specially, and it'd be nice not to have to.

I support that addition of contrib/ tests in the normal test suite,
or even just part of the CI builds. Anything to help catch these things
earlier.

Thanks,
-Stolee

      reply	other threads:[~2020-08-04 13:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 18:57 [PATCH] Revert "contrib: subtree: adjust test to change in fmt-merge-msg" Emily Shaffer
2020-08-03 19:43 ` Junio C Hamano
2020-08-03 22:39   ` Emily Shaffer
2020-08-04 13:12     ` Derrick Stolee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cb1c0f8-53c4-f7c5-d1aa-a9241c511fd0@gmail.com \
    --to=stolee@gmail.com \
    --cc=congdanhqx@gmail.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).