Re: [GSoC] Git Blog 9

[Atharva Raykar <raykar.ath@gmail.com>]

On 19-Jul-2021, at 12:25, ZheNing Hu <adlternative@gmail.com> wrote:
> 
> [...]
> ### BUG REPORT 2
> 
> * What did you do before the bug happened? (Steps to reproduce your issue)
> 
> Normally execute the test under git/t.
> 
> * What did you expect to happen? (Expected behavior)
> 
> Pass the test t/t0500-progress-display.sh.
> 
> * What happened instead? (Actual behavior)
> 
> ```zsh
> $ sh t0500-progress-display.sh -d -i -v
> ...
> expecting success of 0500.3 'progress display breaks long lines #1':
> sed -e "s/Z$//" >expect <<\EOF &&
> Working hard.......2.........3.........4.........5.........6: 0%
> (100/100000)<CR>
> Working hard.......2.........3.........4.........5.........6: 1%
> (1000/100000)<CR>
> Working hard.......2.........3.........4.........5.........6: Z
> 10% (10000/100000)<CR>
> 100% (100000/100000)<CR>
> 100% (100000/100000), done.
> EOF
> 
> cat >in <<-\EOF &&
> progress 100
> progress 1000
> progress 10000
> progress 100000
> EOF
> test-tool progress --total=100000 \
> "Working hard.......2.........3.........4.........5.........6" \
> <in 2>stderr &&
> 
> show_cr <stderr >out &&
> test_cmp expect out
> 
> --- expect 2021-07-19 06:09:39.800189433 +0000
> +++ out 2021-07-19 06:09:39.803522767 +0000
> @@ -1,6 +1,5 @@
> Working hard.......2.........3.........4.........5.........6: 0%
> (100/100000)<CR>
> Working hard.......2.........3.........4.........5.........6: 1%
> (1000/100000)<CR>
> -Working hard.......2.........3.........4.........5.........6:
> - 10% (10000/100000)<CR>
> - 100% (100000/100000)<CR>
> - 100% (100000/100000), done.
> +Working hard.......2.........3.........4.........5.........6: 10%
> (10000/100000)<CR>
> +Working hard.......2.........3.........4.........5.........6: 100%
> (100000/100000)<CR>
> +Working hard.......2.........3.........4.........5.........6: 100%
> (100000/100000), done.
> not ok 3 - progress display breaks long lines #1
> #
> # sed -e "s/Z$//" >expect <<\EOF &&
> # Working hard.......2.........3.........4.........5.........6: 0%
> (100/100000)<CR>
> # Working hard.......2.........3.........4.........5.........6: 1%
> (1000/100000)<CR>
> # Working hard.......2.........3.........4.........5.........6: Z
> # 10% (10000/100000)<CR>
> # 100% (100000/100000)<CR>
> # 100% (100000/100000), done.
> # EOF
> #
> # cat >in <<-\EOF &&
> # progress 100
> # progress 1000
> # progress 10000
> # progress 100000
> # EOF
> # test-tool progress --total=100000 \
> # "Working hard.......2.........3.........4.........5.........6" \
> # <in 2>stderr &&
> #
> # show_cr <stderr >out &&
> # test_cmp expect out
> #
> ```
> 
> * What's different between what you expected and what actually happened?
> 
> It seems that the progress display is not working normally.
> 
> * Anything else you want to add:
> 
> I am thinking:
> 1. Is this bug caused by my own patches?
> So I switched to other branches, including upstream/master, see the bug too.
> 2. Is this bug caused by zsh?
> So I switched to bash, and saw the bug too.
> 3. Does this bug only appear on my Arch-Linux?
> So I asked my classmates (who use arch linux too) to download git/git
> from github and perform the test, see the bug too.
> 4. Does Ubuntu also have this bug?
> No. In the case of using Ubuntu's docker and Centos's virtual machine,
> after cloning git/git from github, they actually passed the test!!!
> 
> So what's wrong with Arch-Linux?

I noticed there's already a thread about this problem here:
https://lore.kernel.org/git/49498ed0-cfd5-2305-cee7-5c5939a19bcf@campoint.net/

This seems to be a bug with a recent bash, and a fix was suggested there.

> * [System Info]
> 
> ```
> git version:
> git version 2.32.0
> cpu: x86_64
> no commit associated with this build
> sizeof-long: 8
> sizeof-size_t: 8
> shell-path: /bin/sh
> uname: Linux 5.12.15-arch1-1 #1 SMP PREEMPT Wed, 07 Jul 2021 23:35:29
> +0000 x86_64
> compiler info: gnuc: 11.1
> libc info: glibc: 2.33
> $SHELL (typically, interactive shell): /bin/zsh
> ```
> 
> * [Enabled Hooks]
> 
> None.
> 
> [...]

---
Atharva Raykar
ಅಥರ್ವ ರಾಯ್ಕರ್
अथर्व रायकर