git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Philip Oakley" <philipoakley@iee.org>
To: <git@vger.kernel.org>,
	"Friedrich Spee von Langenfeld" <stehlampen@arcor.de>
Subject: Re: Errors and other unpleasant things found by Cppcheck
Date: Mon, 8 Jan 2018 11:43:42 -0000	[thread overview]
Message-ID: <5D41958DFAC74BD8B69761D171C572DB@PhilipOakley> (raw)
In-Reply-To: 5fb2c981-7a7b-5a0f-f2bb-b16189980d9b@arcor.de

From: "Friedrich Spee von Langenfeld" <stehlampen@arcor.de>
> Hi,
>
> I analyzed the GitHub repository with Cppcheck. The resulting XML file
> is attached. Please open it in Cppcheck to view it comfortably.
>
> Especially the bunch of errors could be of interest to you.
>
Hi,

Thanks for the submission.

The list prefers that useful information is in plain text so as to avoid 
opening file types that may hide undesirable effects.

Was your analysis part of an organised scan, or a personal insight? It would 
help to know the background.

The project does have a number of known and accepted cases of 'unitialised 
variables' and known memory leaks which are acceptable in those cases.

If you picked out the few key issues that you feel should be addressed then 
a patch can be considered, e.g. the suggestion of the wildmatch macro (L263) 
that depends on the order of evaluation of side effects.

--
Philip 


      reply	other threads:[~2018-01-08 11:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-06 22:13 Errors and other unpleasant things found by Cppcheck Friedrich Spee von Langenfeld
2018-01-08 11:43 ` Philip Oakley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5D41958DFAC74BD8B69761D171C572DB@PhilipOakley \
    --to=philipoakley@iee.org \
    --cc=git@vger.kernel.org \
    --cc=stehlampen@arcor.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).