From: "Jakub Narębski" <jnareb@gmail.com>
To: Brian Henderson <henderson.bj@gmail.com>, git@vger.kernel.org
Cc: Jeff King <peff@peff.net>
Subject: Re: [PATCH 0/3] diff-highlight: add support for git log --graph output.
Date: Fri, 29 Jul 2016 09:46:37 +0200 [thread overview]
Message-ID: <579B09DD.9000603@gmail.com> (raw)
In-Reply-To: <20160728162712.GA29220@tci.corp.yp.com>
W dniu 2016-07-28 o 18:27, Brian Henderson pisze:
> Hi, I've been working with Jeff King on this patch, but he encouraged me to
> email the list.
>
> I recently learned about the diff-highlight tool and find it very helpful,
> however, I frequently use the --graph option to git log which breaks the tool.
> This patch looks to fix this.
>
> I wanted to try and add some tests as well, but I was unsure what number to
> pick for the second digit. As there were limited tests in the contrib directory
> (only t93xx and one t7900) I just chose the next number in the 9xxx range.
> Please let me know if I need to change it.
>
> I'm also not super happy about my test case for the graph option. If anyone has
> any better ideas, please let me know!
>
> Brian Henderson (3):
> diff-highlight: add some tests.
> diff-highlight: add failing test for handling --graph output.
> diff-highlight: add support for --graph output.
Could you please follow SubmittingPatches, and send patches in separate emails,
inline, with those emails being replies to cover letter (like `git format-patch`
and `git send-email` would do), and not as attachments to cover letter?
With email as it stands it is really difficult to review individual
patches.
>
> contrib/diff-highlight/Makefile | 5 +
> contrib/diff-highlight/diff-highlight | 13 +--
> contrib/diff-highlight/t/Makefile | 19 ++++
> contrib/diff-highlight/t/t9400-diff-highlight.sh | 76 ++++++++++++++++
> contrib/diff-highlight/t/test-diff-highlight.sh | 111 +++++++++++++++++++++++
> 5 files changed, 218 insertions(+), 6 deletions(-)
> create mode 100644 contrib/diff-highlight/Makefile
> create mode 100644 contrib/diff-highlight/t/Makefile
> create mode 100644 contrib/diff-highlight/t/t9400-diff-highlight.sh
> create mode 100644 contrib/diff-highlight/t/test-diff-highlight.sh
>
next prev parent reply other threads:[~2016-07-29 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 16:27 [PATCH 0/3] diff-highlight: add support for git log --graph output Brian Henderson
2016-07-29 7:46 ` Jakub Narębski [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-07-29 14:51 Brian Henderson
2016-07-29 16:40 ` Jeff King
2016-07-30 15:11 Brian Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579B09DD.9000603@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=henderson.bj@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).