From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 155BA1F744 for ; Wed, 20 Jul 2016 18:22:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754983AbcGTSWo (ORCPT ); Wed, 20 Jul 2016 14:22:44 -0400 Received: from siwi.pair.com ([209.68.5.199]:40313 "EHLO siwi.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755002AbcGTSWl (ORCPT ); Wed, 20 Jul 2016 14:22:41 -0400 Received: from [10.160.15.137] (unknown [167.220.148.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by siwi.pair.com (Postfix) with ESMTPSA id 65EF6845E9; Wed, 20 Jul 2016 14:22:40 -0400 (EDT) Subject: Re: [PATCH v1 4/6] Expanded branch header for Porcelain Status V2 To: Jeff King , Jeff Hostetler References: <1468966258-11191-1-git-send-email-jeffhost@microsoft.com> <1468966258-11191-5-git-send-email-jeffhost@microsoft.com> <20160720160635.GC24902@sigill.intra.peff.net> Cc: git@vger.kernel.org, gitster@pobox.com From: Jeff Hostetler Message-ID: <578FC0E8.4010102@jeffhostetler.com> Date: Wed, 20 Jul 2016 14:20:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160720160635.GC24902@sigill.intra.peff.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 07/20/2016 12:06 PM, Jeff King wrote: > On Tue, Jul 19, 2016 at 06:10:56PM -0400, Jeff Hostetler wrote: > >> + } else { >> + /* >> + * TODO All of various print routines allow for s->branch to be null. >> + * TODO When can this happen and what should we report here? >> + */ >> + fprintf(s->fp, " %s", "(unknown)"); >> + } > > IIRC, it happens when HEAD points to a broken ref. So something like: > > git init > echo broken >.git/refs/heads/master > > would cause resolving HEAD to return NULL. That worked and I see "(unknown)". This is a bit of a nit, but is there a value we'd like to see there, such as "(unknown)" or "(broken)" or "(missing)" in that case? (And make it clear that this is a different case from "(detached)".) I'm thinking it would be nicer to always have a field there for parsing. Jeff