From: Jeremiah Mahler <jmmahler@gmail.com>
To: git@vger.kernel.org
Cc: Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH 2/3] tree-walk: simplify via strnncmp()
Date: Mon, 16 Jun 2014 12:13:57 -0700 [thread overview]
Message-ID: <571d131f6ebeadb33999fe086656cb642710fb6f.1402945507.git.jmmahler@gmail.com> (raw)
In-Reply-To: <cover.1402945507.git.jmmahler@gmail.com>
In-Reply-To: <cover.1402945507.git.jmmahler@gmail.com>
Simplify tree-walk.c using the strnncmp() function and remove the
name_compare() function.
Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
---
tree-walk.c | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/tree-walk.c b/tree-walk.c
index 4dc86c7..efbd3b7 100644
--- a/tree-walk.c
+++ b/tree-walk.c
@@ -144,16 +144,6 @@ struct tree_desc_x {
struct tree_desc_skip *skip;
};
-static int name_compare(const char *a, int a_len,
- const char *b, int b_len)
-{
- int len = (a_len < b_len) ? a_len : b_len;
- int cmp = memcmp(a, b, len);
- if (cmp)
- return cmp;
- return (a_len - b_len);
-}
-
static int check_entry_match(const char *a, int a_len, const char *b, int b_len)
{
/*
@@ -174,7 +164,7 @@ static int check_entry_match(const char *a, int a_len, const char *b, int b_len)
* scanning further.
*/
- int cmp = name_compare(a, a_len, b, b_len);
+ int cmp = strnncmp(a, a_len, b, b_len);
/* Most common case first -- reading sync'd trees */
if (!cmp)
@@ -369,7 +359,7 @@ int traverse_trees(int n, struct tree_desc *t, struct traverse_info *info)
first_len = len;
continue;
}
- if (name_compare(e->path, len, first, first_len) < 0) {
+ if (strnncmp(e->path, len, first, first_len) < 0) {
first = e->path;
first_len = len;
}
@@ -383,7 +373,7 @@ int traverse_trees(int n, struct tree_desc *t, struct traverse_info *info)
if (!e->path)
continue;
len = tree_entry_len(e);
- if (name_compare(e->path, len, first, first_len))
+ if (strnncmp(e->path, len, first, first_len))
entry_clear(e);
}
}
--
2.0.0
next prev parent reply other threads:[~2014-06-16 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 19:13 [PATCH 0/3] add strnncmp() function Jeremiah Mahler
2014-06-16 19:13 ` [PATCH 1/3] " Jeremiah Mahler
2014-06-16 20:16 ` Jonathan Nieder
2014-06-16 19:13 ` Jeremiah Mahler [this message]
2014-06-16 20:18 ` [PATCH 2/3] tree-walk: simplify via strnncmp() Jonathan Nieder
2014-06-17 7:13 ` Jeremiah Mahler
2014-06-16 19:13 ` [PATCH 3/3] unpack-trees: " Jeremiah Mahler
2014-06-16 20:19 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571d131f6ebeadb33999fe086656cb642710fb6f.1402945507.git.jmmahler@gmail.com \
--to=jmmahler@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).