* "gitk --author=foo" shows also parent
@ 2016-04-26 13:08 Nikolai Kosjar
2016-04-26 14:06 ` Mike Rappazzo
0 siblings, 1 reply; 4+ messages in thread
From: Nikolai Kosjar @ 2016-04-26 13:08 UTC (permalink / raw)
To: git
Hi!
$ gitk --author=foo
...seems to show also the parent of each author-matched commit, whereas
$ git log --author=foo
does not. Is this intended or a bug? I've stumbled over this while
configuring a gitk view with the author field.
Nikolai
# Setup
~/work/gitkBug % git init .
~/work/gitkBug % touch file1 file2
~/work/gitkBug % git add file1
~/work/gitkBug % git commit "--author=MrFoo <foo@world>" file1 -m "add
file1"
~/work/gitkBug % git add file2
~/work/gitkBug % git commit "--author=MrBar <bar@world>" file2 -m "add
file2"
# TEST: git log --author - OK
~/work/gitkBug % git log --author=MrBar # OK, as expected
commit 8aa4a4f651162bcb2275a1e9ee23fc1bb7226097
Author: MrBar <bar@world>
Date: Tue Apr 26 14:22:58 2016 +0200
add file2
# TEST: gitk --author - OPS
~/work/gitkBug % gitk --author=MrBar # Ops, gitk shows also the parent
commit
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: "gitk --author=foo" shows also parent
2016-04-26 13:08 "gitk --author=foo" shows also parent Nikolai Kosjar
@ 2016-04-26 14:06 ` Mike Rappazzo
2016-04-26 16:12 ` Nikolai Kosjar
0 siblings, 1 reply; 4+ messages in thread
From: Mike Rappazzo @ 2016-04-26 14:06 UTC (permalink / raw)
To: Nikolai Kosjar; +Cc: Git List, paulus
On Tue, Apr 26, 2016 at 9:08 AM, Nikolai Kosjar <nikolai.kosjar@qt.io> wrote:
> Hi!
>
> $ gitk --author=foo
>
> ...seems to show also the parent of each author-matched commit, whereas
>
> $ git log --author=foo
>
> does not. Is this intended or a bug? I've stumbled over this while
> configuring a gitk view with the author field.
I believe that this is intentional. Notice that the parent commit's
circle is just outlined
compared to the selected authored commits are filled. I consider this
the context
of the commits you are looking at.
>
> Nikolai
>
>
>
>
>
> # Setup
> ~/work/gitkBug % git init .
> ~/work/gitkBug % touch file1 file2
> ~/work/gitkBug % git add file1
> ~/work/gitkBug % git commit "--author=MrFoo <foo@world>" file1 -m "add
> file1"
> ~/work/gitkBug % git add file2
> ~/work/gitkBug % git commit "--author=MrBar <bar@world>" file2 -m "add
> file2"
>
> # TEST: git log --author - OK
> ~/work/gitkBug % git log --author=MrBar # OK, as expected
> commit 8aa4a4f651162bcb2275a1e9ee23fc1bb7226097
> Author: MrBar <bar@world>
> Date: Tue Apr 26 14:22:58 2016 +0200
>
> add file2
>
> # TEST: gitk --author - OPS
> ~/work/gitkBug % gitk --author=MrBar # Ops, gitk shows also the parent
> commit
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: "gitk --author=foo" shows also parent
2016-04-26 14:06 ` Mike Rappazzo
@ 2016-04-26 16:12 ` Nikolai Kosjar
2016-04-26 17:52 ` Jeff King
0 siblings, 1 reply; 4+ messages in thread
From: Nikolai Kosjar @ 2016-04-26 16:12 UTC (permalink / raw)
To: Mike Rappazzo; +Cc: Git List, paulus
On 04/26/2016 04:06 PM, Mike Rappazzo wrote:
> On Tue, Apr 26, 2016 at 9:08 AM, Nikolai Kosjar <nikolai.kosjar@qt.io> wrote:
>> Hi!
>>
>> $ gitk --author=foo
>>
>> ...seems to show also the parent of each author-matched commit, whereas
>>
>> $ git log --author=foo
>>
>> does not. Is this intended or a bug? I've stumbled over this while
>> configuring a gitk view with the author field.
>
> I believe that this is intentional. Notice that the parent commit's
> circle is just outlined
> compared to the selected authored commits are filled. I consider this
> the context
> of the commits you are looking at.
Hmm, then I'm not interested in the context since it's too noisy. Is
there any way to suppress this?
Nikolai
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: "gitk --author=foo" shows also parent
2016-04-26 16:12 ` Nikolai Kosjar
@ 2016-04-26 17:52 ` Jeff King
0 siblings, 0 replies; 4+ messages in thread
From: Jeff King @ 2016-04-26 17:52 UTC (permalink / raw)
To: Nikolai Kosjar; +Cc: Mike Rappazzo, Git List, paulus
On Tue, Apr 26, 2016 at 06:12:48PM +0200, Nikolai Kosjar wrote:
> >I believe that this is intentional. Notice that the parent commit's
> >circle is just outlined
> >compared to the selected authored commits are filled. I consider this
> >the context
> >of the commits you are looking at.
>
> Hmm, then I'm not interested in the context since it's too noisy. Is there
> any way to suppress this?
I am not a gitk user, but AFAIK, no. Gitk uses "--boundary" to ask git
for the bottom boundary of each string of commits. There is
unfortunately no "--no-boundary" option to override this (and I just
tried adding one, and it doesn't seem to work; gitk is perhaps too
aggressive in the way it passes along --boundary).
So I think it would require a patch to gitk.
-Peff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-26 17:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-26 13:08 "gitk --author=foo" shows also parent Nikolai Kosjar
2016-04-26 14:06 ` Mike Rappazzo
2016-04-26 16:12 ` Nikolai Kosjar
2016-04-26 17:52 ` Jeff King
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).