From: Ben Peart <peartben@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] unpack-trees: allow missing CE_SKIP_WORKTREE objs
Date: Tue, 9 Oct 2018 10:49:24 -0400 [thread overview]
Message-ID: <56cc6e57-d1e3-1182-4290-c8b6fa796534@gmail.com> (raw)
In-Reply-To: <xmqqpnwjpivb.fsf@gitster-ct.c.googlers.com>
On 10/9/2018 5:30 AM, Junio C Hamano wrote:
> Jonathan Tan <jonathantanmy@google.com> writes:
>
>> @@ -1635,6 +1635,7 @@ int unpack_trees(unsigned len, struct tree_desc *t, struct unpack_trees_options
>> o->result.cache_tree = cache_tree();
>> if (!cache_tree_fully_valid(o->result.cache_tree))
>> cache_tree_update(&o->result,
>> + WRITE_TREE_SKIP_WORKTREE_MISSING_OK |
>> WRITE_TREE_SILENT |
>> WRITE_TREE_REPAIR);
>> }
>
> Hmmmm. Should this be passing the bit unconditionally? Shouldn't
> it be set only when we are doing lazy clone? A non-lazy clone that
> merely uses sparse checkout has nowhere else to turn to if it loses
> a blob object that currently is not necessary to complete a checkout,
> unlike a repository with promisor.
>
I agree. I believe this logic should only be triggered when running in
a partial clone repo. Otherwise, we're potentially changing the behavior
of 'normal' repos unnecessarily.
next prev parent reply other threads:[~2018-10-09 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 21:48 [PATCH] unpack-trees: allow missing CE_SKIP_WORKTREE objs Jonathan Tan
2018-10-09 9:27 ` Junio C Hamano
2018-10-09 9:30 ` Junio C Hamano
2018-10-09 14:49 ` Ben Peart [this message]
2018-10-09 14:48 ` Ben Peart
2018-10-09 18:40 ` [PATCH v2] cache-tree: skip some blob checks in partial clone Jonathan Tan
2018-10-10 1:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56cc6e57-d1e3-1182-4290-c8b6fa796534@gmail.com \
--to=peartben@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).