From: "Dana How" <danahow@gmail.com>
To: "Nicolas Pitre" <nico@cam.org>
Cc: "Junio C Hamano" <junkio@cox.net>,
"Git Mailing List" <git@vger.kernel.org>,
danahow@gmail.com
Subject: Re: [PATCH v2] Custom compression levels for objects and packs
Date: Tue, 8 May 2007 23:46:57 -0700 [thread overview]
Message-ID: <56b7f5510705082346m32d3c48dj987fd9b0a6118c10@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.0.99.0705082031370.24220@xanadu.home>
On 5/8/07, Nicolas Pitre <nico@cam.org> wrote:
> On Tue, 8 May 2007, Dana How wrote:
> > On 5/8/07, Nicolas Pitre <nico@cam.org> wrote:
> > > On Tue, 8 May 2007, Junio C Hamano wrote:
> > > If we want the fallback logic to work, at some point we must remember if
> > > the current value is the default or if it is the result of an explicit
> > > config option.
> > I can leave as-is, or use a magic value like -99 and
> > depend on it not colliding with values in zlib.h.
> And where would you set those variables to a sensible default in the
> absence of any config option?
This is why I used the _seen variables,
but they are not necessary -- see 3rd option below.
Unfortunately we agreed a day or two ago to use a config rule like
used_value = isset(var1) ? var1 : isset(var2) ? var2 : DEFAULT.
This doesn't interact well with each variable being processed
completely independently in git_config() and the callbacks it calls.
The isset() value is "out-of-band"; either store it in the _seen
variables, or some special value in used_value .
Which makes the most sense:
* Leave _seen as-is;
* Move pack.compression recognition into config.c which means
the _seen variables would all be local to config.c;
* Use some special value, and if still present replace it with the default
at the end of git_config() using extra code;
* Change the config rule to something simpler.
I like the 2nd and the 4th. You didn't like the 4th.
Shall I change to the 2nd?
Thanks,
--
Dana L. How danahow@gmail.com +1 650 804 5991 cell
next prev parent reply other threads:[~2007-05-09 6:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 22:38 [PATCH v2] Custom compression levels for objects and packs Dana How
2007-05-08 23:56 ` Junio C Hamano
2007-05-09 0:16 ` Nicolas Pitre
2007-05-09 0:29 ` Dana How
2007-05-09 1:03 ` Nicolas Pitre
2007-05-09 6:46 ` Dana How [this message]
2007-05-09 7:13 ` Junio C Hamano
2007-05-09 0:25 ` Dana How
2007-05-09 1:23 ` Nicolas Pitre
2007-05-09 9:21 ` Dana How
2007-05-09 15:27 ` Nicolas Pitre
2007-05-09 16:26 ` Junio C Hamano
2007-05-09 16:42 ` Dana How
2007-05-09 16:59 ` [PATCH] make "repack -f" imply "pack-objects --no-reuse-object" Nicolas Pitre
2007-05-09 18:42 ` [PATCH] deprecate the new loose object header format Nicolas Pitre
2007-05-09 20:16 ` Dana How
2007-05-09 20:42 ` Nicolas Pitre
2007-05-09 21:00 ` Dana How
2007-05-09 5:59 ` [PATCH v2] Custom compression levels for objects and packs Junio C Hamano
2007-05-09 6:24 ` Dana How
2007-05-09 0:30 ` Petr Baudis
2007-05-09 13:56 ` Theodore Tso
2007-05-09 16:44 ` Dana How
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56b7f5510705082346m32d3c48dj987fd9b0a6118c10@mail.gmail.com \
--to=danahow@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).