From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Sixt Subject: Re: [PATCH 1/4] config --show-origin: report paths with forward slashes Date: Wed, 30 Mar 2016 07:52:09 +0200 Message-ID: <56FB6989.8070906@kdbg.org> References: <8beb1c208e33e1de8f272caa22fb7a0b662ca4cc.1458668543.git.johannes.schindelin@gmx.de> <56F8E435.3020304@kdbg.org> <56FAD506.4050701@kdbg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Junio C Hamano , git@vger.kernel.org, Lars Schneider , Kazutoshi SATODA , Eric Wong To: Johannes Schindelin X-From: git-owner@vger.kernel.org Wed Mar 30 07:52:42 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1al93X-0008SV-Ue for gcvg-git-2@plane.gmane.org; Wed, 30 Mar 2016 07:52:40 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752196AbcC3FwP (ORCPT ); Wed, 30 Mar 2016 01:52:15 -0400 Received: from bsmtp.bon.at ([213.33.87.14]:44127 "EHLO bsmtp.bon.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751791AbcC3FwO (ORCPT ); Wed, 30 Mar 2016 01:52:14 -0400 Received: from dx.site (unknown [93.83.142.38]) by bsmtp.bon.at (Postfix) with ESMTPSA id 3qZcGz4hjCz5tlH; Wed, 30 Mar 2016 07:52:11 +0200 (CEST) Received: from [IPv6:::1] (localhost [IPv6:::1]) by dx.site (Postfix) with ESMTP id 080D029B3; Wed, 30 Mar 2016 07:52:09 +0200 (CEST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 In-Reply-To: <56FAD506.4050701@kdbg.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Am 29.03.2016 um 21:18 schrieb Johannes Sixt: > Am 28.03.2016 um 17:14 schrieb Johannes Schindelin: >> The problem with your patch is that it does not account for backslashes in >> paths resulting in quoting. I am afraid that your patch will most likely >> *not* let the tests pass in Git for Windows SDK, while my patch does. > > It does pass. The reason is that pwd -W generates forward slashes. It just occurred to me that we might be observing a difference in behavior of pwd -W between the modern MSYS2 bash and the old MSYS1 bash that I am using. If that is the case the tests won't pass under MSYS2 without the change made by 5ca6b7bb (config --show-origin: report paths with forward slashes). -- Hannes