git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>,
	Jiang Xin <worldhello.net@gmail.com>
Subject: Re: [ANNOUNCE] Git v2.8.0-rc2
Date: Wed, 16 Mar 2016 16:32:56 +0100	[thread overview]
Message-ID: <56E97CA8.8070400@drmicha.warpmail.net> (raw)
In-Reply-To: <CACsJy8CyLGtYpPnwdhS-AD4d2pcU7RVv=OxPEePcHYhFpDh4pg@mail.gmail.com>

Duy Nguyen venit, vidit, dixit 16.03.2016 14:40:
> On Wed, Mar 16, 2016 at 8:33 PM, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
>> In hindsight, what happened must have been like this:
>>
>> "ahead " was marked properly for l10n and translated in the past.
>>
>> 7a76c28 (status: disable translation when --porcelain is used,
>> 2014-03-20) introduced those extra parentheses. Matthieu probably didn't
>> rerun "make pot" and "msgmerge" so that he didn't notice the consequences.
> 
> .po(t) files are _very_ noisy because they record line numbers and
> that pretty much guarantees huge diffs. Even I as a former translator
> do not want to "make pot" and see the differences. If only msgmerge
> supports an output without line numbers...
> 

echo '*.po diff=po' >>.gitattributes
echo '*.pot diff=po' >>.gitattributes
git config diff.po.textconv "msgcat --indent --no-location"

With or without the indent, that gives a pretty clean diff. [It's
unfortunate that one half of that config is in-tree, one-half is not.]

The way it currently is, "non-l10n" coders don't even notice when their
changes affect the set of marked strings. But I guess ususally that's
not a problem.

For our l10n coordinator it is impossible to decide whether a "git.pot"
diff between two runs looks the way it is supposed to look - he would
have to be aware of all code changes that intentionally change the
marked strings. (Likewise, for the translators.)

So, really, the "actual coders" know best whether their changes should
affect l10n or not, so they should be made more aware of it. Forcing
"make pot" (and maybe more) on everyone sounds a bit harsh, but what
else can we do?

Michael

  reply	other threads:[~2016-03-16 15:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-10 23:04 [ANNOUNCE] Git v2.8.0-rc2 Junio C Hamano
2016-03-12  9:11 ` Max Horn
2016-03-14 18:10   ` Junio C Hamano
2016-03-14 15:29 ` Michael J Gruber
2016-03-14 15:30   ` [PATCH] wt-status: allow "ahead " to be picked up by l10n Michael J Gruber
2016-03-14 15:57     ` Junio C Hamano
2016-03-14 15:56   ` [ANNOUNCE] Git v2.8.0-rc2 Junio C Hamano
2016-03-14 17:47     ` Junio C Hamano
2016-03-16 13:33       ` Michael J Gruber
2016-03-16 13:40         ` Duy Nguyen
2016-03-16 15:32           ` Michael J Gruber [this message]
2016-03-16 16:30             ` Junio C Hamano
2016-03-17 14:51               ` Michael J Gruber
2016-03-17 15:14                 ` [RFC/PATCH] Makefile: allow po generation through po target Michael J Gruber
2016-03-17 22:42                   ` Junio C Hamano
2016-03-17 16:15                 ` [ANNOUNCE] Git v2.8.0-rc2 Junio C Hamano
2016-03-20  9:45         ` Jiang Xin
2016-03-20 15:11           ` Michael J Gruber
2016-03-21 20:01             ` Junio C Hamano
2016-03-22 10:00               ` Michael J Gruber
2016-03-22 17:43                 ` Junio C Hamano
2016-03-15 16:42   ` Jiang Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E97CA8.8070400@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).