From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] daemon.c: mark a file-local symbol as static
Date: Mon, 22 Feb 2016 00:33:23 +0000 [thread overview]
Message-ID: <56CA5753.9030308@ramsayjones.plus.com> (raw)
In-Reply-To: <20160221232510.GB4094@sigill.intra.peff.net>
On 21/02/16 23:25, Jeff King wrote:
> On Sun, Feb 21, 2016 at 05:33:38PM +0000, Ramsay Jones wrote:
>
>> If you need to re-roll your 'jk/tighten-alloc' branch, could you
>> please squash this into the relevant patch. (ie. "convert manual
>> allocations to argv_array").
>
> Thanks, will do. You notice these with sparse, as I recall? I've meant
> to look into running that myself, but it looks like we are not
> warning-free with sparse currently. I see complaints like:
>
> connect.c:377:40: warning: incorrect type in argument 2 (invalid types)
> connect.c:377:40: expected union __CONST_SOCKADDR_ARG [usertype] __addr
> connect.c:377:40: got struct sockaddr *ai_addr
>
> As far as I can tell, that's just noise. Do you have a ready-made recipe
> for silencing it?
Ah, I think you must be on a very old version of sparse.
I tend to run a (non-released, reasonably) up-to-date version built
directly from the sparse repo at:
git://git.kernel.org/pub/scm/devel/sparse/sparse.git
[You just prompted me to check, I'm running version v0.5.0-30-gca3309e
which is actually a little behind master, which is v0.5.0-44-g40791b9.
This is even further behind the maintainers master branch.]
On Linux, there is a single warning, which results from a hard-coded
value (max size of memcpy et. al., used for the kernel) which should
at least be settable from the command line (I have a patch somewhere
which I have not sent upstream).
On cygwin, currently, there are several other warnings, which can be
silenced by fixups to sparse (again I have some patches ...)
(Also, static-check.pl comes in handy for these types of 'problem'.)
HTH
ATB,
Ramsay Jones
next prev parent reply other threads:[~2016-02-22 0:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 17:33 [PATCH] daemon.c: mark a file-local symbol as static Ramsay Jones
2016-02-21 23:25 ` Jeff King
2016-02-22 0:33 ` Ramsay Jones [this message]
2016-02-22 21:18 ` Jeff King
2016-02-23 0:49 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CA5753.9030308@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).