From: Victoria Dye <vdye@github.com>
To: Junio C Hamano <gitster@pobox.com>,
Victoria Dye via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, derrickstolee@github.com,
Johannes.Schindelin@gmx.de, steadmon@google.com,
chooglen@google.com
Subject: Re: [PATCH] Documentation: add ReviewingGuidelines
Date: Tue, 13 Sep 2022 18:11:00 -0500 [thread overview]
Message-ID: <5685773e-db83-6b92-ff42-0d51e6e6a22e@github.com> (raw)
In-Reply-To: <xmqqr10f88jm.fsf@gitster.g>
Junio C Hamano wrote:
> "Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Victoria Dye <vdye@github.com>
>>
>> Add a reviewing guidelines document including advice and common terminology
>> used in Git mailing list reviews. The document is included in the
>> 'TECH_DOCS' list in order to include it in Git's published documentation.
>>
>> Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>> Helped-by: Derrick Stolee <derrickstolee@github.com>
>> Signed-off-by: Victoria Dye <vdye@github.com>
>> ---
>
> I've commented on the text but haven't seen anybody else reviewing.
> No interest? Everybody silently happy?
My guess is that there aren't as many eyes on this as there might typically
be because of Git Merge. In any case, I plan to re-roll based on your
feedback [1] (ideally) by the end of the week if other reviews aren't sent
in the meantime.
I'm hoping there's a bit more interest after Git Merge. With reviewing being
such an integral part of contribution to Git, I'm really interested in
hearing people's thoughts on what should/shouldn't be in this document.
[1] https://lore.kernel.org/git/xmqqwnacibbm.fsf@gitster.g/
next prev parent reply other threads:[~2022-09-13 23:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 18:13 [PATCH] Documentation: add ReviewingGuidelines Victoria Dye via GitGitGadget
2022-09-09 19:42 ` Junio C Hamano
2022-09-13 17:54 ` Junio C Hamano
2022-09-13 23:11 ` Victoria Dye [this message]
2022-09-19 15:08 ` Derrick Stolee
2022-09-19 15:48 ` Johannes Schindelin
2022-09-15 23:25 ` Josh Steadmon
2022-09-19 18:17 ` Glen Choo
2022-09-19 19:12 ` [PATCH v2] " Victoria Dye via GitGitGadget
2022-09-19 20:15 ` Josh Steadmon
2022-09-19 21:37 ` Junio C Hamano
2022-09-20 0:43 ` Elijah Newren
2022-09-20 21:23 ` Konstantin Ryabitsev
2022-09-22 4:24 ` Shaoxuan Yuan
2022-09-22 13:29 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5685773e-db83-6b92-ff42-0d51e6e6a22e@github.com \
--to=vdye@github.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chooglen@google.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).