From: "Torsten Bögershausen" <tboegi@web.de>
To: Christian Couder <christian.couder@gmail.com>, git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
"David Turner" <dturner@twopensource.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [RFC/PATCH 6/8] config: add core.untrackedCache
Date: Wed, 02 Dec 2015 08:12:57 +0100 [thread overview]
Message-ID: <565E99F9.2020906@web.de> (raw)
In-Reply-To: <1449001899-18956-7-git-send-email-chriscool@tuxfamily.org>
On 12/01/2015 09:31 PM, Christian Couder wrote:
> When we know that mtime is fully supported by the environment, we
> might want the untracked cache to be always used by default without
> any mtime test or kernel version check being performed.
I'm not sure if ever "we know" ?
How can we know without testing ?
I personaly can not say "I know" in all the different system I am using,
so I always want to test and verify that the untracked cache is working,
before I rely on it.
> Also when we know that mtime is not supported by the environment,
> for example because the repo is shared over a network file system,
> then we might want 'git update-index --untracked-cache' to fail
> immediately instead of it testing if it works (because it might
> work on some systems using the repo over the network file system
> but not others).
Same here.
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> Documentation/config.txt | 10 ++++++++++
> Documentation/git-update-index.txt | 11 +++++++++--
> builtin/update-index.c | 28 ++++++++++++++++++----------
> cache.h | 1 +
> config.c | 10 ++++++++++
> contrib/completion/git-completion.bash | 1 +
> dir.c | 2 +-
> environment.c | 1 +
> wt-status.c | 9 +++++++++
> 9 files changed, 60 insertions(+), 13 deletions(-)
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index b4b0194..bf176ff 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -308,6 +308,16 @@ core.trustctime::
> crawlers and some backup systems).
> See linkgit:git-update-index[1]. True by default.
>
> +core.untrackedCache::
> + If unset or set to 'default' or 'check', untracked cache will
> + not be enabled by default and when
> + 'update-index --untracked-cache' is called, Git will test if
> + mtime is working properly before enabling it. If set to false,
> + Git will refuse to enable untracked cache even if
> + '--force-untracked-cache' is used. If set to true, Git will
> + blindly enabled untracked cache by default without testing if
> + it works. See linkgit:git-update-index[1].
> +
Please no.
The command line option should always be able to overwrite any settings
from a config file.
Sorry, I may missing the big picture here.
What exactly should be achieved ?
A config variable that should ask Git to always try to use the untracked
cache ?
Or a config variable that tells Git to never use the untracked cache ?
Or a combination ?
core.untrackedCache::
false: Never use the untracked cache ?
true: Always try to use the untracked cache ?
Try means: probe, and if the probing fails, record that if fails in the index,
for this hostname/os/kernel/path (Don't remember all the details)
unset: As today,
next prev parent reply other threads:[~2015-12-02 7:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 20:31 [RFC/PATCH 0/8] Untracked cache improvements Christian Couder
2015-12-01 20:31 ` [RFC/PATCH 1/8] update-index: add untracked cache notifications Christian Couder
2015-12-02 19:16 ` Duy Nguyen
2015-12-07 9:08 ` Christian Couder
2015-12-07 9:12 ` Duy Nguyen
2015-12-01 20:31 ` [RFC/PATCH 2/8] update-index: add --test-untracked-cache Christian Couder
2015-12-02 19:17 ` Duy Nguyen
2015-12-07 6:18 ` Christian Couder
2015-12-01 20:31 ` [RFC/PATCH 3/8] update-index: move 'uc' var declaration Christian Couder
2015-12-01 20:31 ` [RFC/PATCH 4/8] dir: add add_untracked_cache() Christian Couder
2015-12-01 20:31 ` [RFC/PATCH 5/8] dir: add remove_untracked_cache() Christian Couder
2015-12-01 20:31 ` [RFC/PATCH 6/8] config: add core.untrackedCache Christian Couder
2015-12-02 7:12 ` Torsten Bögershausen [this message]
2015-12-02 10:32 ` Ævar Arnfjörð Bjarmason
2015-12-03 16:10 ` Torsten Bögershausen
2015-12-03 16:35 ` Christian Couder
2015-12-04 17:54 ` Torsten Bögershausen
2015-12-04 19:44 ` Christian Couder
2015-12-01 20:31 ` [RFC/PATCH 7/8] update-index: prevent --untracked-cache from performing tests Christian Couder
2015-12-02 19:18 ` Duy Nguyen
2015-12-07 5:40 ` Christian Couder
2015-12-01 20:31 ` [RFC/PATCH 8/8] update-index: make core.untrackedCache a bool Christian Couder
2015-12-05 12:44 ` Torsten Bögershausen
2015-12-07 10:32 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565E99F9.2020906@web.de \
--to=tboegi@web.de \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).