From: Sebastian Schuberth <sschuberth@gmail.com>
To: larsxschneider@gmail.com, git@vger.kernel.org
Cc: johannes.schindelin@gmx.de, tboegi@web.de, pw@padd.com
Subject: Re: [PATCH v3 1/3] Add Travis CI support
Date: Mon, 12 Oct 2015 10:05:02 +0200 [thread overview]
Message-ID: <561B69AE.8050403@gmail.com> (raw)
In-Reply-To: <1444586102-82557-2-git-send-email-larsxschneider@gmail.com>
On 10/11/2015 19:55, larsxschneider@gmail.com wrote:
> + sudo apt-get update -qq
> + sudo apt-get install -y apt-transport-https
> + sudo apt-get install perforce-server git-lfs
Why no "-y" also in this line, or append these to the previous line?
Or maybe even better, like [1] does, also use "--qq" (which implies
"-y") for "apt-get install"?
> +install: make configure && ./configure
> +
> +before_script: make
> +
> +script: make --quiet test
Semantically, it does not seem correct to me that configuarion goes to
the install step. As "make test" will build git anyway, I'd instead
propose to get rid of "install" and just say:
before_script: make configure && ./configure
script: make --quiet test
[1] https://github.com/git/git/pull/154/files
Regards,
Sebastian
next prev parent reply other threads:[~2015-10-12 8:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 17:54 [PATCH v3 0/3] Add Travis CI support larsxschneider
2015-10-11 17:55 ` [PATCH v3 1/3] " larsxschneider
2015-10-11 20:40 ` Eric Sunshine
2015-10-12 16:46 ` Lars Schneider
2015-10-12 8:05 ` Sebastian Schuberth [this message]
2015-10-12 16:02 ` Junio C Hamano
2015-10-12 18:42 ` Sebastian Schuberth
2015-10-12 19:40 ` Lars Schneider
2015-10-12 19:48 ` Sebastian Schuberth
2015-10-12 20:10 ` Matthieu Moy
2015-10-12 17:12 ` Lars Schneider
2015-10-12 19:37 ` Sebastian Schuberth
2015-10-12 19:43 ` Lars Schneider
2015-10-12 19:53 ` Sebastian Schuberth
2015-10-12 20:20 ` Matthieu Moy
2015-10-14 22:52 ` Lars Schneider
2015-10-15 8:07 ` Matthieu Moy
2015-10-15 9:02 ` Jean-Noël Avila
2015-10-13 10:32 ` Jean-Noël Avila
2015-10-15 7:59 ` Lars Schneider
2015-10-15 8:12 ` Matthieu Moy
2015-10-15 10:35 ` Lars Schneider
2015-10-15 10:50 ` Johannes Schindelin
2015-10-15 17:14 ` Matthieu Moy
2015-10-11 17:55 ` [PATCH v3 2/3] git-p4: Improve test case portability for t9815 git-p4-submit-fail larsxschneider
2015-10-11 17:55 ` [PATCH v3 3/3] git-p4: Skip t9819 test case on case insensitive file systems larsxschneider
2015-10-12 6:47 ` Luke Diamand
2015-10-12 16:07 ` [PATCH v3 0/3] Add Travis CI support Junio C Hamano
2015-10-12 16:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561B69AE.8050403@gmail.com \
--to=sschuberth@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=larsxschneider@gmail.com \
--cc=pw@padd.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).