From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Stefan Beller <sbeller@google.com>
Cc: Stefan Beller <stefanbeller@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] submodule-parallel-fetch: make some file local symbols static
Date: Thu, 1 Oct 2015 19:43:46 +0100 [thread overview]
Message-ID: <560D7EE2.8060403@ramsayjones.plus.com> (raw)
In-Reply-To: <CAGZ79kZzLtK7+rHRG_misaa9=fWF+oyeryBa+kbD3F+EB=3LMQ@mail.gmail.com>
On 01/10/15 18:05, Stefan Beller wrote:
> On Thu, Oct 1, 2015 at 5:02 AM, Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
>>
[snip]
>> diff --git a/run-command.c b/run-command.c
>> index 341b23b..347d22e 100644
>> --- a/run-command.c
>> +++ b/run-command.c
>> @@ -865,7 +865,7 @@ int capture_command(struct child_process *cmd, struct strbuf *buf, size_t hint)
>> return finish_command(cmd);
>> }
>>
>> -struct parallel_processes {
>> +static struct parallel_processes {
>
> will pickup in a reroll
Thanks
>
>> void *data;
>>
>> int max_processes;
>> diff --git a/submodule.c b/submodule.c
>> index bd6e208..638efb5 100644
>> --- a/submodule.c
>> +++ b/submodule.c
>> @@ -622,8 +622,8 @@ struct submodule_parallel_fetch {
>> };
>> #define SPF_INIT {0, ARGV_ARRAY_INIT, NULL, NULL, 0, 0, 0}
>>
>> -int get_next_submodule(void *data, struct child_process *cp,
>> - struct strbuf *err);
>> +static int get_next_submodule(void *data, struct child_process *cp,
>> + struct strbuf *err);
>
> I thought I had this in yesterdays reroll (v6). Oh you're referring to
> the version
> from the 28th (I forgot to label them v5 I suppose).
Ah! I thought I'd seen it on the list. (I thought I was going crazy) ;-)
Sorry, my fault. I just assumed that today's pu branch would have your
latest patches - I didn't actually check that.
Note that the first hunk, above, is actually new (I hadn't noticed it
before).
>
> I will also get rid of the forward declaration.
Thanks!
ATB,
Ramsay Jones
>
>>
>> static int fetch_start_failure(void *data, struct child_process *cp,
>> struct strbuf *err)
>> @@ -682,8 +682,8 @@ out:
>> return spf.result;
>> }
>>
>> -int get_next_submodule(void *data, struct child_process *cp,
>> - struct strbuf *err)
>> +static int get_next_submodule(void *data, struct child_process *cp,
>> + struct strbuf *err)
>> {
>> int ret = 0;
>> struct submodule_parallel_fetch *spf = data;
>> --
next prev parent reply other threads:[~2015-10-01 18:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 12:02 [PATCH] submodule-parallel-fetch: make some file local symbols static Ramsay Jones
2015-10-01 17:05 ` Stefan Beller
2015-10-01 18:43 ` Ramsay Jones [this message]
2015-10-02 17:45 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2015-09-25 15:15 Ramsay Jones
2015-09-25 15:40 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560D7EE2.8060403@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
--cc=stefanbeller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).