From: Stephan Beyer <s-beyer@gmx.net>
To: git@vger.kernel.org
Subject: t5561 failing after make PROFILE=GEN
Date: Wed, 23 Sep 2015 01:21:39 +0200 [thread overview]
Message-ID: <5601E283.2030507@gmx.net> (raw)
Hi,
I noticed that t5561 fails on my machine when compiling with
"make PROFILE=GEN". Luckily, the reason seems to be the test only,
not the tool it is testing.
I tracked it down that far that log_div() (defined in
t/t5561-http-backend.sh but used in t/t556x_common) appends
the given text to the access.log *before* the last GET log entry
is written.
The test code does it right (as far as I managed to look over it),
so this is maybe some odd flushing behavior of the web server?
On the other hand, the problem only occurs with PROFILE=GEN
but the web server should be independent of the Git compile-time
configuration, right? Looks weird to me but I did not dig deep.
Replacing the log_div() implementation by "return 0" and removing
the implied output solves the problem without breaking any test
functionality. (For more clarity, the log_div() calls and definitions
should be removed.) I refrained from sending this trivial patch
because I am not sure if this is the right way to cope with the issue.
Best
Stephan
next reply other threads:[~2015-09-22 23:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 23:21 Stephan Beyer [this message]
2015-09-23 23:24 ` t5561 failing after make PROFILE=GEN Jeff King
2015-09-24 0:20 ` [PATCH] t5561: get rid of racy appending to logfile Stephan Beyer
2015-09-24 1:45 ` Jeff King
2015-09-24 18:12 ` Stephan Beyer
2015-09-24 18:23 ` Jeff King
2015-09-25 15:50 ` Junio C Hamano
2015-09-24 0:22 ` t5561 failing after make PROFILE=GEN Stephan Beyer
2015-09-24 1:41 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5601E283.2030507@gmx.net \
--to=s-beyer@gmx.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).