mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Haller <>
To: Pratyush Yadav <>
Subject: Re: [PATCH 1/1] git-gui: fix colored label backgrounds when using themed widgets
Date: Tue, 8 Dec 2020 16:20:56 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 06.12.20 14:07, Pratyush Yadav wrote:
> On 02/12/20 09:52AM, Stefan Haller wrote:
>> On 01.12.20 21:06, Pratyush Yadav wrote:
>>> Hi Stefan,
>>> Thanks for the patch.
>>> On 22/11/20 08:45PM, Stefan Haller wrote:
>>>> The aqua theme on Mac doesn't support changing the background color for labels
>>>> and frames [1]. Since the red, green, and yellow backgrounds of the labels for
>>>> unstaged and staged files and the diff pane are so important design elements of
>>>> git gui's main window, it's not acceptable for them to have grey backgrounds on
>>>> Mac.
>>> I unfortunately don't have access to a Mac machine to I can't test this 
>>> patch.
>> I could send screenshots if that helps.
> Yes, that would be helpful.

Here are some screenshots; with and without the patch, with and without
ttk, and in light mode and dark mode.


  reply	other threads:[~2020-12-08 15:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-22 19:45 [PATCH 0/1] git-gui: fix colored label backgrounds on Mac Stefan Haller
2020-11-22 19:45 ` [PATCH 1/1] git-gui: fix colored label backgrounds when using themed widgets Stefan Haller
2020-12-01 20:06   ` Pratyush Yadav
2020-12-02  8:52     ` Stefan Haller
2020-12-06 13:07       ` Pratyush Yadav
2020-12-08 15:20         ` Stefan Haller [this message]
2020-12-17 19:03   ` Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).