From: Luke Diamand <luke@diamand.org>
To: larsxschneider@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader
Date: Thu, 03 Sep 2015 20:55:46 +0100 [thread overview]
Message-ID: <55E8A5C2.9090500@diamand.org> (raw)
In-Reply-To: <1441298148-63885-2-git-send-email-larsxschneider@gmail.com>
On 03/09/15 17:35, larsxschneider@gmail.com wrote:
> From: Lars Schneider <larsxschneider@gmail.com>
>
I think this commit may need some explanation!
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
> git-p4.py | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/git-p4.py b/git-p4.py
> index 073f87b..c139cab 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -604,9 +604,12 @@ def gitBranchExists(branch):
>
> _gitConfig = {}
>
> -def gitConfig(key):
> +def gitConfig(key, typeSpecifier=None):
> if not _gitConfig.has_key(key):
> - cmd = [ "git", "config", key ]
> + cmd = [ "git", "config" ]
> + if typeSpecifier:
> + cmd += [ typeSpecifier ]
> + cmd += [ key ]
> s = read_pipe(cmd, ignore_error=True)
> _gitConfig[key] = s.strip()
> return _gitConfig[key]
> @@ -617,10 +620,7 @@ def gitConfigBool(key):
> in the config."""
>
> if not _gitConfig.has_key(key):
> - cmd = [ "git", "config", "--bool", key ]
> - s = read_pipe(cmd, ignore_error=True)
> - v = s.strip()
> - _gitConfig[key] = v == "true"
> + _gitConfig[key] = gitConfig(key, '--bool') == "true"
> return _gitConfig[key]
>
> def gitConfigList(key):
>
next prev parent reply other threads:[~2015-09-03 19:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 16:35 [PATCH v2] git-p4: add support for large file systems larsxschneider
2015-09-03 16:35 ` [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader larsxschneider
2015-09-03 19:55 ` Luke Diamand [this message]
2015-09-03 20:14 ` Lars Schneider
2015-09-03 20:18 ` Junio C Hamano
2015-09-03 20:53 ` Lars Schneider
2015-09-03 21:31 ` Junio C Hamano
2015-09-04 7:49 ` Lars Schneider
2015-09-03 16:35 ` [PATCH v2 2/4] git-p4: add gitConfigInt reader larsxschneider
2015-09-03 19:57 ` Luke Diamand
2015-09-03 20:17 ` Lars Schneider
2015-09-03 20:20 ` Luke Diamand
2015-09-03 16:35 ` [PATCH v2 3/4] git-p4: return an empty list if a list config has no values larsxschneider
2015-09-03 16:35 ` [PATCH v2 4/4] git-p4: add support for large file systems larsxschneider
2015-09-03 20:03 ` Luke Diamand
2015-09-03 20:49 ` Lars Schneider
2015-09-04 8:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E8A5C2.9090500@diamand.org \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).