From: Mark Levedahl <mlevedahl@gmail.com>
To: Adam Dinwoodie <adam@dinwoodie.org>, git@vger.kernel.org
Cc: Eric Blake <eblake@redhat.com>,
"Shawn O . Pearce" <spearce@spearce.org>,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Subject: Re: [PATCH] config.mak.uname: Cygwin: Use renames for creation
Date: Sat, 8 Aug 2015 16:47:46 -0400 [thread overview]
Message-ID: <55C66AF2.3060706@gmail.com> (raw)
In-Reply-To: <1438979428-5888-1-git-send-email-adam@dinwoodie.org>
On 08/07/2015 04:30 PM, Adam Dinwoodie wrote:
> When generating build options for Cygwin, enable
> OBJECT_CREATION_USES_RENAMES. This is necessary to use Git on Windows
> shared directories, and is already enabled for the MinGW and plain
> Windows builds.
>
> This problem was reported on the Cygwin mailing list at
> https://cygwin.com/ml/cygwin/2015-08/msg00102.html (amongst others) and
> is being applied as a manual patch to the Cygwin builds until the patch
> is taken here.
>
> Reported-by: Peter Rosin <peda@lysator.liu.se>
> Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>
> ---
> config.mak.uname | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index 943c439..be5cbec 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -187,6 +187,7 @@ ifeq ($(uname_O),Cygwin)
> X = .exe
> UNRELIABLE_FSTAT = UnfortunatelyYes
> SPARSE_FLAGS = -isystem /usr/include/w32api -Wno-one-bit-signed-bitfield
> + OBJECT_CREATION_USES_RENAMES = UnfortunatelyNeedsTo
> endif
> ifeq ($(uname_S),FreeBSD)
> NEEDS_LIBICONV = YesPlease
I've been supporting use of git on cygwin since about 2008, this issue
has never risen that I know. Whatever issue is being patched around
here, if truly repeatable, should be handled by the cygwin dll as that
code is focused on providing full linux compatibility. If git on linux
does need this patch, git on cygwin should not, either. So, I vote
against this.
Mark
next prev parent reply other threads:[~2015-08-08 20:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 20:30 [PATCH] config.mak.uname: Cygwin: Use renames for creation Adam Dinwoodie
2015-08-08 20:47 ` Mark Levedahl [this message]
2015-08-08 21:06 ` brian m. carlson
2015-08-09 2:01 ` Adam Dinwoodie
2015-08-09 9:01 ` Johannes Schindelin
2015-08-09 17:05 ` Adam Dinwoodie
2015-08-10 19:08 ` Junio C Hamano
2015-08-11 10:05 ` Adam Dinwoodie
2015-08-18 15:44 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C66AF2.3060706@gmail.com \
--to=mlevedahl@gmail.com \
--cc=adam@dinwoodie.org \
--cc=eblake@redhat.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).