From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Anatol Rudolph <a.rudolph@2vizcon.com>, git@vger.kernel.org
Subject: Re: git branch command is incompatible with bash
Date: Tue, 28 Jul 2015 19:27:46 +0200 [thread overview]
Message-ID: <55B7BB92.30006@kdbg.org> (raw)
In-Reply-To: <xmqq4mkogvb7.fsf@gitster.dls.corp.google.com>
Am 28.07.2015 um 17:23 schrieb Junio C Hamano:
> Johannes Sixt <j6t@kdbg.org> writes:
>
>> Are you trying to say that the result of 'rev-parse --abbrev-ref HEAD'
>> is suboptimal and that of 'symbolic-ref --short HEAD' is OK?
>
> My "Interesting" was primarily about that I wasn't aware of the
> "--abbrev-ref" option.
>
> Yes, I am sure some time ago I accepted a patch to add it, but I
> simply do not see the point, especially because the "--short" option
> to symbolic-ref feels much more superiour. "What branch am I on?"
> is about symbolic refs, rev-parse is about revisions.
>
> I can see that "symbolic-ref --short" is much newer than the other
> one, so addition of "--abbrev-ref" to "rev-parse" may have been a
> mistake made while being desperate (i.e. not having a way to do so
> with plumbing, we wanted "some" way to do so and chose poorly).
Heh. Originially, I was about to suggest
git symbolic-ref -q --short HEAD || git rev-parse --abbrev HEAD
in order to handle the detached HEAD case by printing the abbreviated
commit name, only to learn that this doesn't do what I expected. Looking
at the man page of rev-parse, I discovered --abbrev-ref. And learned
that I actually should have used --short instead of --abbrev in the
above rev-parse command.
Confusing...
-- Hannes
next prev parent reply other threads:[~2015-07-28 17:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 12:12 git branch command is incompatible with bash Anatol Rudolph
2015-07-27 21:11 ` Johannes Sixt
2015-07-27 21:49 ` Junio C Hamano
2015-07-28 7:28 ` Johannes Sixt
2015-07-28 10:01 ` Jakub Narębski
2015-07-28 15:23 ` Junio C Hamano
2015-07-28 16:25 ` Jeff King
2015-07-28 17:27 ` Johannes Sixt [this message]
2015-07-29 0:23 ` Scott Schmit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B7BB92.30006@kdbg.org \
--to=j6t@kdbg.org \
--cc=a.rudolph@2vizcon.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).