From: Michael Haggerty <mhagger@alum.mit.edu>
To: David Turner <dturner@twopensource.com>,
git@vger.kernel.org, j6t@kdbg.org
Subject: Re: [PATCH v8 0/7] ref backend preamble
Date: Tue, 21 Jul 2015 07:02:43 -0700 [thread overview]
Message-ID: <55AE5103.7020907@alum.mit.edu> (raw)
In-Reply-To: <1436482260-28088-1-git-send-email-dturner@twopensource.com>
On 07/09/2015 03:50 PM, David Turner wrote:
> The current state of the discussion on alternate ref backends is that
> we're going to continue to store pseudorefs (e.g. CHERRY_PICK_HEAD) as
> files in $GIT_DIR. So this re-roll of the refs backend preamble
> doesn't do anything to pseudorefs. It just does reflog stuff.
>
> In addition, this version removes the over-aggressive die() on reflog
> update failure from v7. It adds the REF_FORCE_CREATE_REFLOG flag, as
> Michael Haggerty suggested. And it fixes commit message or two, as
> suggested. I believe this addresses all comments I've seen on v7.
>
> This addresses Johannes Sixt's concerns too, by removing the offending
> code.
I just reviewed the whole patch series. Aside from the minor points that
I commented on, it all looks good to me.
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
prev parent reply other threads:[~2015-07-21 14:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 22:50 [PATCH v8 0/7] ref backend preamble David Turner
2015-07-09 22:50 ` [PATCH v8 1/7] refs.c: add err arguments to reflog functions David Turner
2015-07-21 13:17 ` Michael Haggerty
2015-07-09 22:50 ` [PATCH v8 2/7] refs: Break out check for reflog autocreation David Turner
2015-07-09 22:50 ` [PATCH v8 3/7] refs: new public ref function: safe_create_reflog David Turner
2015-07-09 22:50 ` [PATCH v8 4/7] git-reflog: add exists command David Turner
2015-07-21 13:27 ` Michael Haggerty
2015-07-09 22:50 ` [PATCH v8 5/7] refs: add REF_FORCE_CREATE_REFLOG flag David Turner
2015-07-09 22:50 ` [PATCH v8 6/7] update-ref and tag: add --create-reflog arg David Turner
2015-07-21 13:46 ` Michael Haggerty
2015-07-09 22:51 ` [PATCH v8 7/7] git-stash: use update-ref --create-reflog instead of creating files David Turner
2015-07-10 14:34 ` [PATCH v8 0/7] ref backend preamble Philip Oakley
2015-07-10 17:51 ` David Turner
2015-07-21 14:02 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AE5103.7020907@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).