From: Johannes Sixt <j6t@kdbg.org>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: Ben Walton <bdwalton@gmail.com>, gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH 2/2] Fix sed usage in tests to work around broken xpg4/sed on Solaris
Date: Sun, 19 Jul 2015 10:40:48 +0200 [thread overview]
Message-ID: <55AB6290.2090003@kdbg.org> (raw)
In-Reply-To: <fadc4ff7e755913a4c6076165556b56c@www.dscho.org>
Am 19.07.2015 um 09:37 schrieb Johannes Schindelin:
> On 2015-07-19 08:54, Johannes Sixt wrote:
>> Am 18.07.2015 um 17:21 schrieb Ben Walton:
>>> - sed -e s/CHANGE_ME/change_me/ <file >file+ &&
>>> - mv -f file+ file &&
>>> + perl -pi -e "s/CHANGE_ME/change_me/" file &&
>>
>> This is problematic. On Windows, perl -i fails when no backup file
>> extension is specified because perl attempts to replace a file that is
>> still open; that does not work on Windows.
>
> Let's qualify this a bit better: it actually works with the SDK of
> Git for Windows 2.x.
Good to know!
> I really wonder why the previous ">file+ && mv -f file+ file" dance
> needs to be replaced?
The sed must be replaced because some versions on Solaris choke on the
incomplete last line in the file.
-- Hannes
next prev parent reply other threads:[~2015-07-19 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 15:21 [PATCH 2/2] Fix sed usage in tests to work around broken xpg4/sed on Solaris Ben Walton
2015-07-19 3:39 ` Eric Sunshine
2015-07-19 6:54 ` Johannes Sixt
2015-07-19 7:37 ` Johannes Schindelin
2015-07-19 8:40 ` Johannes Sixt [this message]
2015-07-20 16:07 ` Junio C Hamano
2015-07-22 9:52 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AB6290.2090003@kdbg.org \
--to=j6t@kdbg.org \
--cc=bdwalton@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).