From: Johannes Sixt <j6t@kdbg.org>
To: Beat Bolli <dev+git@drbeat.li>
Cc: git@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH v2] gitk: Add a "Copy commit summary" command
Date: Thu, 16 Jul 2015 22:48:49 +0200 [thread overview]
Message-ID: <55A818B1.4000205@kdbg.org> (raw)
In-Reply-To: <1437060565-4716-1-git-send-email-dev+git@drbeat.li>
Am 16.07.2015 um 17:29 schrieb Beat Bolli:
> When referring to earlier commits in commit messages or other text, one
> of the established formats is
>
> <abbrev-sha> ("<summary>", <author-date>)
>
> Add a "Copy commit summary" command to the context menu that puts this
> text for the currently selected commit on the clipboard. This makes it
> easy for our users to create well-formatted commit references.
>
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> Cc: Paul Mackerras <paulus@samba.org>
> ---
> gitk-git/gitk | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 9a2daf3..72a2756 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -2617,6 +2617,7 @@ proc makewindow {} {
> {mc "Diff selected -> this" command {diffvssel 1}}
> {mc "Make patch" command mkpatch}
> {mc "Create tag" command mktag}
> + {mc "Copy commit summary" command copysummary}
> {mc "Write commit to file" command writecommit}
> {mc "Create new branch" command mkbranch}
> {mc "Cherry-pick this commit" command cherrypick}
> @@ -9341,6 +9342,19 @@ proc mktaggo {} {
> mktagcan
> }
>
> +proc copysummary {} {
> + global rowmenuid commitinfo
> +
> + set id [string range $rowmenuid 0 7]
You abbreviate the commit name to 7 characters. This is too short for
certain repositories to remain unique. In my group, it is customary to
abbreviate to 8 charaters. This reduces the usefulness for my use. If
you don't want to make this a configuration I would suggest to aim for a
longer commit name as it is simpler to delete excess letters after
pasting than to add back the missing ones.
Except for this, I like the idea.
> + set info $commitinfo($rowmenuid)
> + set commit [lindex $info 0]
> + set date [formatdate [lindex $info 2]]
> + set summary "$id (\"$commit\", $date)"
> +
> + clipboard clear
> + clipboard append $summary
> +}
> +
> proc writecommit {} {
> global rowmenuid wrcomtop commitinfo wrcomcmd NS
>
>
-- Hannes
next prev parent reply other threads:[~2015-07-16 20:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 15:29 [PATCH v2] gitk: Add a "Copy commit summary" command Beat Bolli
2015-07-16 17:02 ` Junio C Hamano
2015-07-17 8:50 ` Stefan Haller
2015-07-17 9:16 ` Beat Bolli
2015-07-16 20:48 ` Johannes Sixt [this message]
2015-07-17 9:22 ` Paul Mackerras
2015-07-17 15:30 ` Junio C Hamano
2015-07-18 12:23 ` Paul Mackerras
2015-07-18 12:45 ` Beat Bolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A818B1.4000205@kdbg.org \
--to=j6t@kdbg.org \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).