From: Dragan Simic <dsimic@manjaro.org>
To: "Quang Lê Duy" <leduyquang753@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] Add separator lines into `git log --graph`.
Date: Sun, 07 Apr 2024 10:35:37 +0200 [thread overview]
Message-ID: <559a32ce4bd3060ff2a1c352c62c6161@manjaro.org> (raw)
In-Reply-To: <CACXAH50uHNreqhK9hn9_SPARCCq2gfAOs4krGS-Xa0-5GKSvtg@mail.gmail.com>
On 2024-04-07 09:06, Quang Lê Duy wrote:
> On Sun, Apr 7, 2024 at 12:52 PM Eric Sunshine <sunshine@sunshineco.com>
> wrote:
>> I forgot to mention that application of your patch results in some
>> warnings:
>>
>> % git am add-sep-lines.patch
>> Applying: Add separator lines into `git log --graph`.
>> .git/rebase-apply/patch:61: trailing whitespace.
>> .git/rebase-apply/patch:147: trailing whitespace.
>> .git/rebase-apply/patch:151: trailing whitespace.
>> .git/rebase-apply/patch:160: trailing whitespace.
>> warning: 4 lines add whitespace errors.
>
> Indeed I failed to notice the whitespace `vim` added to the empty
> lines.
> Appreciate your notice.
As a note, vim can be configured to highlight the trailing
whitespace, making it easy to spot.
next prev parent reply other threads:[~2024-04-07 8:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 5:10 [RFC PATCH 0/1] Add lines to `git log --graph` to separate connected regions Lê Duy Quang
2024-04-07 5:10 ` [RFC PATCH 1/1] Add separator lines into `git log --graph` Lê Duy Quang
2024-04-07 5:47 ` Eric Sunshine
2024-04-07 5:52 ` Eric Sunshine
2024-04-07 7:06 ` Quang Lê Duy
2024-04-07 8:35 ` Dragan Simic [this message]
2024-04-07 7:03 ` Quang Lê Duy
2024-04-07 9:07 ` Eric Sunshine
2024-04-07 5:30 ` [RFC PATCH 0/1] Add lines to `git log --graph` to separate connected regions Eric Sunshine
2024-04-07 5:37 ` Junio C Hamano
2024-04-07 6:40 ` Quang Lê Duy
2024-04-07 8:34 ` Dragan Simic
2024-04-07 8:46 ` Quang Lê Duy
2024-04-07 9:13 ` Dragan Simic
2024-04-08 15:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559a32ce4bd3060ff2a1c352c62c6161@manjaro.org \
--to=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=leduyquang753@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).