From: "Torsten Bögershausen" <tboegi@web.de>
To: Matthieu Moy <Matthieu.Moy@imag.fr>, gitster@pobox.com
Cc: git@vger.kernel.org, remi.lespinet@ensimag.grenoble-inp.fr,
guillaume.pages@ensimag.grenoble-inp.fr,
louis--alexandre.stuber@ensimag.grenoble-inp.fr,
antoine.delaite@ensimag.grenoble-inp.fr
Subject: Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line
Date: Tue, 7 Jul 2015 11:37:47 +0200 [thread overview]
Message-ID: <559B9DEB.9030409@web.de> (raw)
In-Reply-To: <1435666611-18429-8-git-send-email-Matthieu.Moy@imag.fr>
#!/usr/bin/perl
Should we have hard-coded PATH to perl here ?
/usr/bin/perl --version
This is perl, v5.10.0 built for darwin-thread-multi-2level
(with 2 registered patches, see perl -V for more detail)
> +
> +my $is_passing = Test::More->builder->is_passing;
> +exit($is_passing ? 0 : 1);
>
This seems to give problems:
debug=t verbose=t ./t9000-addresses.sh
Initialized empty Git repository in /Users/me/projects/git/git.pu/t/trash directory.t9000-addresses/.git/
# run 0: Perl address parsing function (perl /Users/me/projects/git/git.pu/t/t9000/test.pl)
ok 1 - use Git;
ok 2 - same output : Jane
ok 3 - same output : jdoe@example.com
ok 4 - same output : <jdoe@example.com>
ok 5 - same output : Jane <jdoe@example.com>
ok 6 - same output : Jane Doe <jdoe@example.com>
ok 7 - same output : "Jane" <jdoe@example.com>
ok 8 - same output : "Doe, Jane" <jdoe@example.com>
ok 9 - same output : "Jane@:;\>.,()<Doe" <jdoe@example.com>
ok 10 - same output : Jane!\#$%&'*+-/=?^_{|}~Doe' <jdoe@example.com>
ok 11 - same output : "<jdoe@example.com>"
ok 12 - same output : "Jane jdoe@example.com"
ok 13 - same output : Jane Doe <jdoe @ example.com >
ok 14 - same output : Jane Doe < jdoe@example.com >
ok 15 - same output : Jane @ Doe @ Jane @ Doe
ok 16 - same output : "Jane, 'Doe'" <jdoe@example.com>
ok 17 - same output : 'Doe, "Jane' <jdoe@example.com>
ok 18 - same output : "Jane" "Do"e <jdoe@example.com>
ok 19 - same output : "Jane' Doe" <jdoe@example.com>
ok 20 - same output : "Jane Doe <jdoe@example.com>" <jdoe@example.com>
ok 21 - same output : "Jane\" Doe" <jdoe@example.com>
ok 22 - same output : Doe, jane <jdoe@example.com>
ok 23 - same output : "Jane Doe <jdoe@example.com>
ok 24 - same output : 'Jane 'Doe' <jdoe@example.com>
not ok 25 - same output : Jane\ Doe <jdoe@example.com> # TODO known breakage
# Failed (TODO) test 'same output : Jane\ Doe <jdoe@example.com>'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[0] = '"Jane \ Doe" <jdoe@example.com>'
# $expected->[0] = '"Jane\ Doe" <jdoe@example.com>'
not ok 26 - same output : "Doe, Ja"ne <jdoe@example.com> # TODO known breakage
# Failed (TODO) test 'same output : "Doe, Ja"ne <jdoe@example.com>'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[0] = '"Doe, Ja" ne <jdoe@example.com>'
# $expected->[0] = '"Doe, Ja ne" <jdoe@example.com>'
not ok 27 - same output : "Doe, Katarina" Jane <jdoe@example.com> # TODO known breakage
# Failed (TODO) test 'same output : "Doe, Katarina" Jane <jdoe@example.com>'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[0] = '"Doe, Katarina" Jane <jdoe@example.com>'
# $expected->[0] = '"Doe, Katarina Jane" <jdoe@example.com>'
not ok 28 - same output : Jane@:;\.,()<>Doe <jdoe@example.com> # TODO known breakage
# Failed (TODO) test 'same output : Jane@:;\.,()<>Doe <jdoe@example.com>'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[1] = '\.'
# $expected->[1] = '"\."'
not ok 29 - same output : Jane jdoe@example.com # TODO known breakage
# Failed (TODO) test 'same output : Jane jdoe@example.com'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[0] = 'Jane'
# $expected->[0] = 'Janejdoe@example.com'
not ok 30 - same output : <jdoe@example.com> Jane Doe # TODO known breakage
# Failed (TODO) test 'same output : <jdoe@example.com> Jane Doe'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[0] = 'Jane Doe <jdoe@example.com>'
# $expected->[0] = 'jdoe@example.comJaneDoe'
not ok 31 - same output : Jane <jdoe@example.com> Doe # TODO known breakage
# Failed (TODO) test 'same output : Jane <jdoe@example.com> Doe'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[0] = 'Jane Doe <jdoe@example.com>'
# $expected->[0] = 'Jane <jdoe@example.comDoe>'
not ok 32 - same output : "Jane "Kat"a" ri"na" ",Doe" <jdoe@example.com> # TODO known breakage
# Failed (TODO) test 'same output : "Jane "Kat"a" ri"na" ",Doe" <jdoe@example.com>'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[0] = '"Jane " Kat "a" ri "na" ",Doe" <jdoe@example.com>'
# $expected->[0] = '"Jane Kat a ri na ,Doe" <jdoe@example.com>'
not ok 33 - same output : Jane Doe # TODO known breakage
# Failed (TODO) test 'same output : Jane Doe'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[0] = 'Jane'
# $expected->[0] = 'Jane Doe'
not ok 34 - same output : Jane "Doe <jdoe@example.com>" # TODO known breakage
# Failed (TODO) test 'same output : Jane "Doe <jdoe@example.com>"'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[0] = 'Jane'
# $expected->[0] = '"Jane Doe <jdoe@example.com>"'
not ok 35 - same output : \"Jane Doe <jdoe@example.com> # TODO known breakage
# Failed (TODO) test 'same output : \"Jane Doe <jdoe@example.com>'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[0] = '\ " Jane Doe <jdoe@example.com>'
# $expected->[0] = '"\"Jane Doe" <jdoe@example.com>'
not ok 36 - same output : Jane\"\" Doe <jdoe@example.com> # TODO known breakage
# Failed (TODO) test 'same output : Jane\"\" Doe <jdoe@example.com>'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[0] = 'Jane \ " \ " Doe <jdoe@example.com>'
# $expected->[0] = '"Jane\"\" Doe" <jdoe@example.com>'
not ok 37 - same output : 'Jane "Katarina\" \' Doe' <jdoe@example.com> # TODO known breakage
# Failed (TODO) test 'same output : 'Jane "Katarina\" \' Doe' <jdoe@example.com>'
# at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
# Structures begin differing at:
# $got->[0] = ''Jane " Katarina \ " \ ' Doe' <jdoe@example.com>'
# $expected->[0] = '"'Jane Katarina\" \' Doe'" <jdoe@example.com>'
1..37
# test_external test Perl address parsing function failed: perl /Users/me/projects/git/git.pu/t/t9000/test.pl
# expecting no stderr from previous command
# test_external_without_stderr test no stderr: Perl address parsing function failed: perl /Users/me/projects/git/git.pu/t/t9000/test.pl:
# Stderr is:
Can't locate object method "is_passing" via package "Test::Builder" at /Users/me/projects/git/git.pu/t/t9000/test.pl line 66.
# Looks like your test died just after 37.
next prev parent reply other threads:[~2015-07-07 9:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 12:16 [PATCH v7 00/10] send-email address management Matthieu Moy
2015-06-30 12:16 ` [PATCH v7 01/10] t9001-send-email: move script creation in a setup test Matthieu Moy
2015-06-30 12:16 ` [PATCH v7 02/10] send-email: allow aliases in patch header and command script outputs Matthieu Moy
2015-06-30 12:16 ` [PATCH v7 03/10] t9001-send-email: refactor header variable fields replacement Matthieu Moy
2015-06-30 12:16 ` [PATCH v7 04/10] send-email: refactor address list process Matthieu Moy
2015-06-30 12:16 ` [PATCH v7 05/10] send-email: allow use of aliases in the From field of --compose mode Matthieu Moy
2015-06-30 12:16 ` [PATCH v7 06/10] send-email: minor code refactoring Matthieu Moy
2015-06-30 12:16 ` [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line Matthieu Moy
2015-06-30 18:41 ` Junio C Hamano
2015-06-30 19:36 ` Matthieu Moy
2015-06-30 19:43 ` Junio C Hamano
2015-07-01 7:51 ` Remi Lespinet
2015-07-01 8:33 ` Matthieu Moy
2015-07-07 9:37 ` Torsten Bögershausen [this message]
2015-07-07 13:27 ` Matthieu Moy
2015-07-07 13:38 ` [PATCH v8 " Matthieu Moy
2015-07-08 7:16 ` Torsten Bögershausen
2015-07-08 7:28 ` Matthieu Moy
2015-06-30 12:16 ` [PATCH v7 08/10] send-email: consider quote as delimiter instead of character Matthieu Moy
2015-06-30 12:16 ` [PATCH v7 09/10] send-email: allow multiple emails using --cc, --to and --bcc Matthieu Moy
2015-06-30 12:16 ` [PATCH v7 10/10] send-email: suppress meaningless whitespaces in from field Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559B9DEB.9030409@web.de \
--to=tboegi@web.de \
--cc=Matthieu.Moy@imag.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).