* [PATCH 0/1] gitk: Addressing error running on MacOS with large repos.
@ 2019-10-03 20:49 Arash via GitGitGadget
2019-10-03 20:49 ` [PATCH 1/1] " Arash Bannazadeh-Mahani via GitGitGadget
0 siblings, 1 reply; 2+ messages in thread
From: Arash via GitGitGadget @ 2019-10-03 20:49 UTC (permalink / raw)
To: git; +Cc: Arash, Junio C Hamano
gitk: no need to specify all refs, since git log --all is the same as list
is all the refs/commit ids. Also Mac OS has a limit on size of the list of
params for a command line
Arash Bannazadeh-Mahani (1):
gitk: Addressing error running on MacOS with large repos.
gitk-git/gitk | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
base-commit: bc12974a897308fd3254cf0cc90319078fe45eea
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-375%2Faxbannaz%2Fuse.all-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-375/axbannaz/use.all-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/375
--
gitgitgadget
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/1] gitk: Addressing error running on MacOS with large repos.
2019-10-03 20:49 [PATCH 0/1] gitk: Addressing error running on MacOS with large repos Arash via GitGitGadget
@ 2019-10-03 20:49 ` Arash Bannazadeh-Mahani via GitGitGadget
0 siblings, 0 replies; 2+ messages in thread
From: Arash Bannazadeh-Mahani via GitGitGadget @ 2019-10-03 20:49 UTC (permalink / raw)
To: git; +Cc: Arash, Junio C Hamano, Arash Bannazadeh-Mahani
From: Arash Bannazadeh-Mahani <axbannaz@gmail.com>
The change is stemmed from a problem on the MacOS where, if --all
is passed to gitk it should show all the refs/commits graphically.
However, on really large git repos, in my instance a git repo with
over 52,000 commits, gitk will report an error,
"Error executing git log: couldn't execute "git": argument list too long".
Mac OS has a limit of which my large repo exceeds. This works fine on Linux,
however, not sure about Windows.
Looking at gitk script, the decision to have all commit-ids on the command line
comes from return value of parseviewargs() function which uses the value of
"allknown" to return. If it is '1' then --all is translated to a string of all
the commit-ids in the repo, otherwise --all is passed as-is to `git log` cli,
which according to git-log man page it is the same as listing all the
commit-ids.
So, this change is to prevent --all option from being expanded into list
of all refs on the command line.
Signed-off-by: Arash Bannazadeh-Mahani <axbannaz@gmail.com>
---
gitk-git/gitk | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index abe4805ade..96634d9d33 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -250,8 +250,13 @@ proc parseviewargs {n arglist} {
set nextisval 1
lappend glflags $arg
}
- "--not" - "--all" {
+ "--not" {
lappend revargs $arg
+ }
+ "--all" {
+ # we recognize this argument;
+ # no expansion needed, use it with 'git log' as-is
+ set allknown 0
}
"--merge" {
set vmergeonly($n) 1
--
gitgitgadget
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-03 20:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-03 20:49 [PATCH 0/1] gitk: Addressing error running on MacOS with large repos Arash via GitGitGadget
2019-10-03 20:49 ` [PATCH 1/1] " Arash Bannazadeh-Mahani via GitGitGadget
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).