From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Haggerty Subject: Re: [PATCH v10.1 7/7] bisect: allow any terms set by user Date: Sun, 28 Jun 2015 08:46:44 +0200 Message-ID: <558F9854.5080605@alum.mit.edu> References: <1435351183-27100-1-git-send-email-Matthieu.Moy@imag.fr> <558F8B55.1070708@alum.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Christian Couder , Matthieu Moy , git , Antoine Delaite , Louis Stuber To: Junio C Hamano X-From: git-owner@vger.kernel.org Sun Jun 28 08:51:35 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z96RB-0000IU-4b for gcvg-git-2@plane.gmane.org; Sun, 28 Jun 2015 08:51:33 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751227AbbF1GrA (ORCPT ); Sun, 28 Jun 2015 02:47:00 -0400 Received: from alum-mailsec-scanner-7.mit.edu ([18.7.68.19]:53209 "EHLO alum-mailsec-scanner-7.mit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751282AbbF1Gq5 (ORCPT ); Sun, 28 Jun 2015 02:46:57 -0400 X-AuditID: 12074413-f79bd6d000007ac2-89-558f98575d57 Received: from outgoing-alum.mit.edu (OUTGOING-ALUM.MIT.EDU [18.7.68.33]) by alum-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP id 22.04.31426.7589F855; Sun, 28 Jun 2015 02:46:47 -0400 (EDT) Received: from [192.168.69.130] (p5DDB2F50.dip0.t-ipconnect.de [93.219.47.80]) (authenticated bits=0) (User authenticated as mhagger@ALUM.MIT.EDU) by outgoing-alum.mit.edu (8.13.8/8.12.4) with ESMTP id t5S6kiSE007240 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 28 Jun 2015 02:46:46 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 In-Reply-To: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsUixO6iqBs+oz/U4FuXrMXMmdYWt2e2MFt0 XelmsmjovcJs8X/HAhaLJa8fMTuweVxtDvDYOesuu8exY63MHhcvKXt83iQXwBrFbZOUWFIW nJmep2+XwJ2xpfssY8FDwYrf/w8yNjC28XUxcnJICJhI3G69xA5hi0lcuLeerYuRi0NI4DKj xPyOuSwgCSGBc0wS/38VgNi8AtoSp+/fYwWxWQRUJabevMoMYrMJ6Eos6mlm6mLk4BAVCJJ4 /TIXolxQ4uTMJ2BjRATUJCa2HWIBmc8s8J1R4tHn/2CLhQWcJKZ82s4MsXgis8TOHxAJToFA if/vDzGC2MwC6hJ/5l1ihrDlJZq3zmaewCgwC8mSWUjKZiEpW8DIvIpRLjGnNFc3NzEzpzg1 Wbc4OTEvL7VI11wvN7NELzWldBMjJNSFdzDuOil3iFGAg1GJh9dDtz9UiDWxrLgy9xCjJAeT kihvbzdQiC8pP6UyI7E4I76oNCe1+BCjBAezkgjv1gSgHG9KYmVValE+TEqag0VJnFdtibqf kEB6YklqdmpqQWoRTFaGg0NJgtd0OlCjYFFqempFWmZOCUKaiYMTZDiXlEhxal5KalFiaUlG PChW44uB0QqS4gHaawjSzltckJgLFIVoPcWoKCXOWwCSEABJZJTmwY2FJbBXjOJAXwrzHpkG VMUDTH5w3a+ABjMBDV7l3QcyuCQRISXVwOjjVSgTdTCJr0w9jc/LQ795bsehl3JdNT/lD0SW M84923mF1bYvwl7ekr3prOks5+vq0UJ7dndNy5B6NyWI/ehS7j3Wl2/PXHJ/38/9 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On 06/28/2015 08:15 AM, Junio C Hamano wrote: > On Sat, Jun 27, 2015 at 10:51 PM, Michael Haggerty wrote: >> >> I would like to remind everybody of my old claim that it would be >> possible to teach `git bisect` to infer by itself which term means >> "older" and which term means "newer": >> >> http://article.gmane.org/gmane.comp.version-control.git/244036 > > But then one mistake at the beginning and the user will be on a wrong > track during the whole bisect session, no? Unless you make absolutely > clear when making the "intelligent" decision what Git inferred, that is. Definitely, `git bisect` should tell the user what it inferred. > For something complex like bisect, I highly suspect that a tool that is > more intelligent than the end users (more precisely, a tool that it thinks > it is more intelligent) would hurt them more than it helps them. This isn't about making bisect "more intelligent than the end users". It is about not forcing the user cumbersomely to spell out redundant information because the tool is too stupid. If I mark one commit "broken" and another commit "fixed", and the "broken" commit is an ancestor of the "fixed" commit, then it is pretty obvious that I am looking for the commit that caused the transition "broken" -> "fixed". The same if I mark one commit "xyzzy" and the other one "plugh". I understand that the user might make a mistake when marking the initial commits, but as soon as bisect says Commit is an ancestor of , so I will look for the commit that caused the transition from "xyzzy" to "plugh". then I hope the user will notice and correct her/his mistake. For example, a session could be started with git bisect start --mark=broken --mark=fixed and from then on git bisect broken git bisect fixed Or, if the user doesn't want to specify both endpoints on the `start` line, git bisect start git bisect --mark=broken [] git bisect --mark=fixed [] Essentially, specifying `--mark=` once would make `` a shorthand for `--mark=`. Michael -- Michael Haggerty mhagger@alum.mit.edu