From: "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Jeff King" <peff@peff.net>,
"Han-Wen Nienhuys" <hanwen@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"René Scharfe" <l.s.r@web.de>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Neeraj Singh" <nksingh85@gmail.com>,
"Han-Wen Nienhuys" <hanwenn@gmail.com>,
"Han-Wen Nienhuys" <hanwen@google.com>
Subject: [PATCH v7 16/16] reftable: rename typ to type
Date: Mon, 24 Jan 2022 19:13:44 +0000 [thread overview]
Message-ID: <556fc11080a67ceda81f6c39fcdd4dc1098ac1b5.1643051624.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1152.v7.git.git.1643051624.gitgitgadget@gmail.com>
From: Han-Wen Nienhuys <hanwen@google.com>
The 'typ' variable name betrays the Go origins of this code (in Go,
'type' is a reserved word). Since we now have parted ways with the Go
code, simply use 'type'.
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
---
reftable/block.c | 10 ++++----
reftable/merged.c | 6 ++---
reftable/merged.h | 2 +-
reftable/reader.c | 58 +++++++++++++++++++++++------------------------
reftable/record.c | 4 ++--
reftable/writer.c | 32 +++++++++++++-------------
6 files changed, 56 insertions(+), 56 deletions(-)
diff --git a/reftable/block.c b/reftable/block.c
index 80ad10bb794..6c1f70ba563 100644
--- a/reftable/block.c
+++ b/reftable/block.c
@@ -68,14 +68,14 @@ static int block_writer_register_restart(struct block_writer *w, int n,
return 0;
}
-void block_writer_init(struct block_writer *bw, uint8_t typ, uint8_t *buf,
+void block_writer_init(struct block_writer *bw, uint8_t type, uint8_t *buf,
uint32_t block_size, uint32_t header_off, int hash_size)
{
bw->buf = buf;
bw->hash_size = hash_size;
bw->block_size = block_size;
bw->header_off = header_off;
- bw->buf[header_off] = typ;
+ bw->buf[header_off] = type;
bw->next = header_off + 4;
bw->restart_interval = 16;
bw->entries = 0;
@@ -186,7 +186,7 @@ int block_reader_init(struct block_reader *br, struct reftable_block *block,
int hash_size)
{
uint32_t full_block_size = table_block_size;
- uint8_t typ = block->data[header_off];
+ uint8_t type = block->data[header_off];
uint32_t sz = get_be24(block->data + header_off + 1);
int err = 0;
@@ -195,12 +195,12 @@ int block_reader_init(struct block_reader *br, struct reftable_block *block,
uint8_t *restart_bytes = NULL;
uint8_t *uncompressed = NULL;
- if (!reftable_is_block_type(typ)) {
+ if (!reftable_is_block_type(type)) {
err = REFTABLE_FORMAT_ERROR;
goto done;
}
- if (typ == BLOCK_TYPE_LOG) {
+ if (type == BLOCK_TYPE_LOG) {
int block_header_skip = 4 + header_off;
uLongf dst_len = sz - block_header_skip; /* total size of dest
buffer. */
diff --git a/reftable/merged.c b/reftable/merged.c
index 82511762d2a..b5710d5f7a9 100644
--- a/reftable/merged.c
+++ b/reftable/merged.c
@@ -22,7 +22,7 @@ static int merged_iter_init(struct merged_iter *mi)
{
int i = 0;
for (i = 0; i < mi->stack_len; i++) {
- struct reftable_record rec = reftable_new_record(mi->typ);
+ struct reftable_record rec = reftable_new_record(mi->type);
int err = iterator_next(&mi->stack[i], &rec);
if (err < 0) {
return err;
@@ -58,7 +58,7 @@ static int merged_iter_advance_nonnull_subiter(struct merged_iter *mi,
size_t idx)
{
struct pq_entry e = {
- .rec = reftable_new_record(mi->typ),
+ .rec = reftable_new_record(mi->type),
.index = idx,
};
int err = iterator_next(&mi->stack[idx], &e.rec);
@@ -245,7 +245,7 @@ static int merged_table_seek_record(struct reftable_merged_table *mt,
sizeof(struct reftable_iterator) * mt->stack_len);
struct merged_iter merged = {
.stack = iters,
- .typ = reftable_record_type(rec),
+ .type = reftable_record_type(rec),
.hash_id = mt->hash_id,
.suppress_deletions = mt->suppress_deletions,
};
diff --git a/reftable/merged.h b/reftable/merged.h
index 7d9f95d27ed..63f288ff8d6 100644
--- a/reftable/merged.h
+++ b/reftable/merged.h
@@ -28,7 +28,7 @@ struct merged_iter {
struct reftable_iterator *stack;
uint32_t hash_id;
size_t stack_len;
- uint8_t typ;
+ uint8_t type;
int suppress_deletions;
struct merged_iter_pqueue pq;
};
diff --git a/reftable/reader.c b/reftable/reader.c
index 565cda8d5a2..1ecd23bba36 100644
--- a/reftable/reader.c
+++ b/reftable/reader.c
@@ -43,9 +43,9 @@ void block_source_close(struct reftable_block_source *source)
}
static struct reftable_reader_offsets *
-reader_offsets_for(struct reftable_reader *r, uint8_t typ)
+reader_offsets_for(struct reftable_reader *r, uint8_t type)
{
- switch (typ) {
+ switch (type) {
case BLOCK_TYPE_REF:
return &r->ref_offsets;
case BLOCK_TYPE_LOG:
@@ -84,7 +84,7 @@ static int parse_footer(struct reftable_reader *r, uint8_t *footer,
uint8_t *header)
{
uint8_t *f = footer;
- uint8_t first_block_typ;
+ uint8_t first_block_type;
int err = 0;
uint32_t computed_crc;
uint32_t file_crc;
@@ -149,10 +149,10 @@ static int parse_footer(struct reftable_reader *r, uint8_t *footer,
goto done;
}
- first_block_typ = header[header_size(r->version)];
- r->ref_offsets.is_present = (first_block_typ == BLOCK_TYPE_REF);
+ first_block_type = header[header_size(r->version)];
+ r->ref_offsets.is_present = (first_block_type == BLOCK_TYPE_REF);
r->ref_offsets.offset = 0;
- r->log_offsets.is_present = (first_block_typ == BLOCK_TYPE_LOG ||
+ r->log_offsets.is_present = (first_block_type == BLOCK_TYPE_LOG ||
r->log_offsets.offset > 0);
r->obj_offsets.is_present = r->obj_offsets.offset > 0;
err = 0;
@@ -214,7 +214,7 @@ done:
struct table_iter {
struct reftable_reader *r;
- uint8_t typ;
+ uint8_t type;
uint64_t block_off;
struct block_iter bi;
int is_finished;
@@ -228,7 +228,7 @@ static void table_iter_copy_from(struct table_iter *dest,
struct table_iter *src)
{
dest->r = src->r;
- dest->typ = src->typ;
+ dest->type = src->type;
dest->block_off = src->block_off;
dest->is_finished = src->is_finished;
block_iter_copy_from(&dest->bi, &src->bi);
@@ -257,7 +257,7 @@ static void table_iter_block_done(struct table_iter *ti)
ti->bi.next_off = 0;
}
-static int32_t extract_block_size(uint8_t *data, uint8_t *typ, uint64_t off,
+static int32_t extract_block_size(uint8_t *data, uint8_t *type, uint64_t off,
int version)
{
int32_t result = 0;
@@ -266,20 +266,20 @@ static int32_t extract_block_size(uint8_t *data, uint8_t *typ, uint64_t off,
data += header_size(version);
}
- *typ = data[0];
- if (reftable_is_block_type(*typ)) {
+ *type = data[0];
+ if (reftable_is_block_type(*type)) {
result = get_be24(data + 1);
}
return result;
}
int reader_init_block_reader(struct reftable_reader *r, struct block_reader *br,
- uint64_t next_off, uint8_t want_typ)
+ uint64_t next_off, uint8_t want_type)
{
int32_t guess_block_size = r->block_size ? r->block_size :
DEFAULT_BLOCK_SIZE;
struct reftable_block block = { NULL };
- uint8_t block_typ = 0;
+ uint8_t block_type = 0;
int err = 0;
uint32_t header_off = next_off ? 0 : header_size(r->version);
int32_t block_size = 0;
@@ -291,13 +291,13 @@ int reader_init_block_reader(struct reftable_reader *r, struct block_reader *br,
if (err < 0)
goto done;
- block_size = extract_block_size(block.data, &block_typ, next_off,
+ block_size = extract_block_size(block.data, &block_type, next_off,
r->version);
if (block_size < 0) {
err = block_size;
goto done;
}
- if (want_typ != BLOCK_TYPE_ANY && block_typ != want_typ) {
+ if (want_type != BLOCK_TYPE_ANY && block_type != want_type) {
err = 1;
goto done;
}
@@ -326,10 +326,10 @@ static int table_iter_next_block(struct table_iter *dest,
int err = 0;
dest->r = src->r;
- dest->typ = src->typ;
+ dest->type = src->type;
dest->block_off = next_block_off;
- err = reader_init_block_reader(src->r, &br, next_block_off, src->typ);
+ err = reader_init_block_reader(src->r, &br, next_block_off, src->type);
if (err > 0) {
dest->is_finished = 1;
return 1;
@@ -349,7 +349,7 @@ static int table_iter_next_block(struct table_iter *dest,
static int table_iter_next(struct table_iter *ti, struct reftable_record *rec)
{
- if (reftable_record_type(rec) != ti->typ)
+ if (reftable_record_type(rec) != ti->type)
return REFTABLE_API_ERROR;
while (1) {
@@ -404,38 +404,38 @@ static void iterator_from_table_iter(struct reftable_iterator *it,
static int reader_table_iter_at(struct reftable_reader *r,
struct table_iter *ti, uint64_t off,
- uint8_t typ)
+ uint8_t type)
{
struct block_reader br = { 0 };
struct block_reader *brp = NULL;
- int err = reader_init_block_reader(r, &br, off, typ);
+ int err = reader_init_block_reader(r, &br, off, type);
if (err != 0)
return err;
brp = reftable_malloc(sizeof(struct block_reader));
*brp = br;
ti->r = r;
- ti->typ = block_reader_type(brp);
+ ti->type = block_reader_type(brp);
ti->block_off = off;
block_reader_start(brp, &ti->bi);
return 0;
}
static int reader_start(struct reftable_reader *r, struct table_iter *ti,
- uint8_t typ, int index)
+ uint8_t type, int index)
{
- struct reftable_reader_offsets *offs = reader_offsets_for(r, typ);
+ struct reftable_reader_offsets *offs = reader_offsets_for(r, type);
uint64_t off = offs->offset;
if (index) {
off = offs->index_offset;
if (off == 0) {
return 1;
}
- typ = BLOCK_TYPE_INDEX;
+ type = BLOCK_TYPE_INDEX;
}
- return reader_table_iter_at(r, ti, off, typ);
+ return reader_table_iter_at(r, ti, off, type);
}
static int reader_seek_linear(struct reftable_reader *r, struct table_iter *ti,
@@ -522,12 +522,12 @@ static int reader_seek_indexed(struct reftable_reader *r,
if (err < 0)
goto done;
- if (next.typ == reftable_record_type(rec)) {
+ if (next.type == reftable_record_type(rec)) {
err = 0;
break;
}
- if (next.typ != BLOCK_TYPE_INDEX) {
+ if (next.type != BLOCK_TYPE_INDEX) {
err = REFTABLE_FORMAT_ERROR;
break;
}
@@ -582,9 +582,9 @@ static int reader_seek_internal(struct reftable_reader *r,
static int reader_seek(struct reftable_reader *r, struct reftable_iterator *it,
struct reftable_record *rec)
{
- uint8_t typ = reftable_record_type(rec);
+ uint8_t type = reftable_record_type(rec);
- struct reftable_reader_offsets *offs = reader_offsets_for(r, typ);
+ struct reftable_reader_offsets *offs = reader_offsets_for(r, type);
if (!offs->is_present) {
iterator_set_empty(it);
return 0;
diff --git a/reftable/record.c b/reftable/record.c
index c57bac0e96a..8330b7a2589 100644
--- a/reftable/record.c
+++ b/reftable/record.c
@@ -78,9 +78,9 @@ int put_var_int(struct string_view *dest, uint64_t val)
return n;
}
-int reftable_is_block_type(uint8_t typ)
+int reftable_is_block_type(uint8_t type)
{
- switch (typ) {
+ switch (type) {
case BLOCK_TYPE_REF:
case BLOCK_TYPE_LOG:
case BLOCK_TYPE_OBJ:
diff --git a/reftable/writer.c b/reftable/writer.c
index 96a5155ea77..5b768438625 100644
--- a/reftable/writer.c
+++ b/reftable/writer.c
@@ -26,9 +26,9 @@ static void writer_clear_index(struct reftable_writer *w);
static int writer_finish_public_section(struct reftable_writer *w);
static struct reftable_block_stats *
-writer_reftable_block_stats(struct reftable_writer *w, uint8_t typ)
+writer_reftable_block_stats(struct reftable_writer *w, uint8_t type)
{
- switch (typ) {
+ switch (type) {
case 'r':
return &w->stats.ref_stats;
case 'o':
@@ -102,7 +102,7 @@ static int writer_write_header(struct reftable_writer *w, uint8_t *dest)
return header_size(writer_version(w));
}
-static void writer_reinit_block_writer(struct reftable_writer *w, uint8_t typ)
+static void writer_reinit_block_writer(struct reftable_writer *w, uint8_t type)
{
int block_start = 0;
if (w->next == 0) {
@@ -110,7 +110,7 @@ static void writer_reinit_block_writer(struct reftable_writer *w, uint8_t typ)
}
strbuf_release(&w->last_key);
- block_writer_init(&w->block_writer_data, typ, w->block,
+ block_writer_init(&w->block_writer_data, type, w->block,
w->opts.block_size, block_start,
hash_size(w->opts.hash_id));
w->block_writer = &w->block_writer_data;
@@ -375,7 +375,7 @@ int reftable_writer_add_logs(struct reftable_writer *w,
static int writer_finish_section(struct reftable_writer *w)
{
- uint8_t typ = block_writer_type(w->block_writer);
+ uint8_t type = block_writer_type(w->block_writer);
uint64_t index_start = 0;
int max_level = 0;
int threshold = w->opts.unpadded ? 1 : 3;
@@ -434,7 +434,7 @@ static int writer_finish_section(struct reftable_writer *w)
if (err < 0)
return err;
- bstats = writer_reftable_block_stats(w, typ);
+ bstats = writer_reftable_block_stats(w, type);
bstats->index_blocks = w->stats.idx_stats.blocks - before_blocks;
bstats->index_offset = index_start;
bstats->max_index_level = max_level;
@@ -536,17 +536,17 @@ static int writer_dump_object_index(struct reftable_writer *w)
static int writer_finish_public_section(struct reftable_writer *w)
{
- uint8_t typ = 0;
+ uint8_t type = 0;
int err = 0;
if (w->block_writer == NULL)
return 0;
- typ = block_writer_type(w->block_writer);
+ type = block_writer_type(w->block_writer);
err = writer_finish_section(w);
if (err < 0)
return err;
- if (typ == BLOCK_TYPE_REF && !w->opts.skip_index_objects &&
+ if (type == BLOCK_TYPE_REF && !w->opts.skip_index_objects &&
w->stats.ref_stats.index_blocks > 0) {
err = writer_dump_object_index(w);
if (err < 0)
@@ -630,10 +630,10 @@ static const int debug = 0;
static int writer_flush_nonempty_block(struct reftable_writer *w)
{
- uint8_t typ = block_writer_type(w->block_writer);
+ uint8_t type = block_writer_type(w->block_writer);
struct reftable_block_stats *bstats =
- writer_reftable_block_stats(w, typ);
- uint64_t block_typ_off = (bstats->blocks == 0) ? w->next : 0;
+ writer_reftable_block_stats(w, type);
+ uint64_t block_type_off = (bstats->blocks == 0) ? w->next : 0;
int raw_bytes = block_writer_finish(w->block_writer);
int padding = 0;
int err = 0;
@@ -641,12 +641,12 @@ static int writer_flush_nonempty_block(struct reftable_writer *w)
if (raw_bytes < 0)
return raw_bytes;
- if (!w->opts.unpadded && typ != BLOCK_TYPE_LOG) {
+ if (!w->opts.unpadded && type != BLOCK_TYPE_LOG) {
padding = w->opts.block_size - raw_bytes;
}
- if (block_typ_off > 0) {
- bstats->offset = block_typ_off;
+ if (block_type_off > 0) {
+ bstats->offset = block_type_off;
}
bstats->entries += w->block_writer->entries;
@@ -655,7 +655,7 @@ static int writer_flush_nonempty_block(struct reftable_writer *w)
w->stats.blocks++;
if (debug) {
- fprintf(stderr, "block %c off %" PRIu64 " sz %d (%d)\n", typ,
+ fprintf(stderr, "block %c off %" PRIu64 " sz %d (%d)\n", type,
w->next, raw_bytes,
get_be24(w->block + w->block_writer->header_off + 1));
}
--
gitgitgadget
next prev parent reply other threads:[~2022-01-24 19:41 UTC|newest]
Thread overview: 194+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 17:45 [PATCH 00/10] Reftable coverity fixes Han-Wen Nienhuys via GitGitGadget
2021-12-07 17:45 ` [PATCH 01/10] reftable: fix OOB stack write in print functions Han-Wen Nienhuys via GitGitGadget
2021-12-07 17:45 ` [PATCH 02/10] reftable: fix resource leak in error path Han-Wen Nienhuys via GitGitGadget
2021-12-08 14:30 ` Derrick Stolee
2021-12-07 17:45 ` [PATCH 03/10] reftable: fix resource leak blocksource.c Han-Wen Nienhuys via GitGitGadget
2021-12-07 17:45 ` [PATCH 04/10] reftable: check reftable_stack_auto_compact() return value Han-Wen Nienhuys via GitGitGadget
2021-12-07 17:45 ` [PATCH 05/10] reftable: ignore remove() return value in stack_test.c Han-Wen Nienhuys via GitGitGadget
2021-12-07 17:45 ` [PATCH 06/10] reftable: fix resource warning Han-Wen Nienhuys via GitGitGadget
2021-12-07 17:45 ` [PATCH 07/10] reftable: fix NULL derefs in error paths Han-Wen Nienhuys via GitGitGadget
2021-12-07 17:45 ` [PATCH 08/10] reftable: order unittests by complexity Han-Wen Nienhuys via GitGitGadget
2021-12-08 14:32 ` Derrick Stolee
2021-12-07 17:45 ` [PATCH 09/10] reftable: drop stray printf in readwrite_test Han-Wen Nienhuys via GitGitGadget
2021-12-07 17:45 ` [PATCH 10/10] reftable: make reftable_record a tagged union Han-Wen Nienhuys via GitGitGadget
2021-12-07 21:56 ` Junio C Hamano
2021-12-08 2:15 ` Jeff King
2021-12-08 4:13 ` Junio C Hamano
2021-12-08 10:30 ` Han-Wen Nienhuys
2021-12-08 16:35 ` Junio C Hamano
2021-12-08 19:50 ` [PATCH] config.mak.dev: specify -std=gnu99 for gcc/clang Jeff King
2021-12-09 12:05 ` Ævar Arnfjörð Bjarmason
2021-12-10 8:56 ` Jeff King
[not found] ` <220113.86tue7vr6d.gmgdl@evledraar.gmail.com>
2022-01-14 1:38 ` v2.35.0 DEVELOPER=1 regression (was: [PATCH] config.mak.dev: specify -std=gnu99 for gcc/clang) brian m. carlson
2022-01-14 12:01 ` Ævar Arnfjörð Bjarmason
2022-01-14 19:51 ` v2.35.0 DEVELOPER=1 regression Junio C Hamano
2022-01-14 20:41 ` Ævar Arnfjörð Bjarmason
2022-01-14 21:53 ` Junio C Hamano
2022-01-14 23:57 ` Junio C Hamano
2022-01-14 22:35 ` Junio C Hamano
2022-01-14 23:56 ` Ævar Arnfjörð Bjarmason
2022-01-15 0:31 ` Junio C Hamano
2022-01-15 0:41 ` Ævar Arnfjörð Bjarmason
2022-01-15 1:08 ` Junio C Hamano
2022-01-18 12:32 ` Johannes Schindelin
2022-01-18 15:17 ` Ævar Arnfjörð Bjarmason
2022-01-18 20:15 ` Junio C Hamano
2022-01-19 0:29 ` Ævar Arnfjörð Bjarmason
2022-01-19 1:02 ` Junio C Hamano
2022-01-19 1:05 ` Ævar Arnfjörð Bjarmason
2022-01-19 1:19 ` Junio C Hamano
2022-01-18 17:47 ` [PATCH] Makefile: FreeBSD cannot do C99-or-below build Junio C Hamano
2022-01-18 21:47 ` Neeraj Singh
2022-01-18 23:36 ` Ævar Arnfjörð Bjarmason
2022-01-19 0:22 ` Junio C Hamano
2022-01-18 15:14 ` [PATCH] config.mak.dev: fix DEVELOPER=1 on FreeBSD with -std=gnu99 Ævar Arnfjörð Bjarmason
2022-01-18 17:19 ` Junio C Hamano
2022-01-19 0:26 ` Ævar Arnfjörð Bjarmason
2021-12-08 14:35 ` [PATCH 10/10] reftable: make reftable_record a tagged union Derrick Stolee
2021-12-08 14:48 ` Han-Wen Nienhuys
2021-12-08 18:17 ` Derrick Stolee
2021-12-23 17:11 ` Han-Wen Nienhuys
2021-12-08 16:47 ` Junio C Hamano
2021-12-08 17:51 ` Han-Wen Nienhuys
2021-12-08 21:49 ` [PATCH v2 00/11] Reftable coverity fixes Han-Wen Nienhuys via GitGitGadget
2021-12-08 21:49 ` [PATCH v2 01/11] reftable: fix OOB stack write in print functions Han-Wen Nienhuys via GitGitGadget
2021-12-08 21:49 ` [PATCH v2 02/11] reftable: fix resource leak in error path Han-Wen Nienhuys via GitGitGadget
2021-12-08 21:49 ` [PATCH v2 03/11] reftable: fix resource leak blocksource.c Han-Wen Nienhuys via GitGitGadget
2021-12-08 21:49 ` [PATCH v2 04/11] reftable: check reftable_stack_auto_compact() return value Han-Wen Nienhuys via GitGitGadget
2021-12-08 21:49 ` [PATCH v2 05/11] reftable: ignore remove() return value in stack_test.c Han-Wen Nienhuys via GitGitGadget
2021-12-08 21:49 ` [PATCH v2 06/11] reftable: fix resource warning Han-Wen Nienhuys via GitGitGadget
2021-12-08 21:49 ` [PATCH v2 07/11] reftable: fix NULL derefs in error paths Han-Wen Nienhuys via GitGitGadget
2021-12-08 21:49 ` [PATCH v2 08/11] reftable: order unittests by complexity Han-Wen Nienhuys via GitGitGadget
2021-12-08 21:49 ` [PATCH v2 09/11] reftable: drop stray printf in readwrite_test Han-Wen Nienhuys via GitGitGadget
2021-12-08 21:49 ` [PATCH v2 10/11] reftable: handle null refnames in reftable_ref_record_equal Han-Wen Nienhuys via GitGitGadget
2021-12-08 21:49 ` [PATCH v2 11/11] reftable: make reftable_record a tagged union Han-Wen Nienhuys via GitGitGadget
2021-12-09 5:31 ` [PATCH v2 00/11] Reftable coverity fixes Jeff King
2021-12-13 16:01 ` [PATCH v3 " Han-Wen Nienhuys via GitGitGadget
2021-12-13 16:01 ` [PATCH v3 01/11] reftable: fix OOB stack write in print functions Han-Wen Nienhuys via GitGitGadget
2021-12-13 16:01 ` [PATCH v3 02/11] reftable: fix resource leak in error path Han-Wen Nienhuys via GitGitGadget
2021-12-13 16:19 ` Ævar Arnfjörð Bjarmason
2021-12-13 16:44 ` Han-Wen Nienhuys
2021-12-13 22:10 ` Junio C Hamano
2021-12-13 16:01 ` [PATCH v3 03/11] reftable: fix resource leak blocksource.c Han-Wen Nienhuys via GitGitGadget
2021-12-13 16:01 ` [PATCH v3 04/11] reftable: check reftable_stack_auto_compact() return value Han-Wen Nienhuys via GitGitGadget
2021-12-13 16:01 ` [PATCH v3 05/11] reftable: ignore remove() return value in stack_test.c Han-Wen Nienhuys via GitGitGadget
2021-12-13 16:01 ` [PATCH v3 06/11] reftable: fix resource warning Han-Wen Nienhuys via GitGitGadget
2021-12-13 16:01 ` [PATCH v3 07/11] reftable: fix NULL derefs in error paths Han-Wen Nienhuys via GitGitGadget
2021-12-13 16:24 ` Ævar Arnfjörð Bjarmason
2021-12-13 16:01 ` [PATCH v3 08/11] reftable: order unittests by complexity Han-Wen Nienhuys via GitGitGadget
2021-12-13 16:25 ` Ævar Arnfjörð Bjarmason
2021-12-13 16:45 ` Han-Wen Nienhuys
2021-12-13 22:13 ` Junio C Hamano
2021-12-13 16:01 ` [PATCH v3 09/11] reftable: drop stray printf in readwrite_test Han-Wen Nienhuys via GitGitGadget
2021-12-13 16:26 ` Ævar Arnfjörð Bjarmason
2021-12-13 16:46 ` Han-Wen Nienhuys
2021-12-13 16:01 ` [PATCH v3 10/11] reftable: handle null refnames in reftable_ref_record_equal Han-Wen Nienhuys via GitGitGadget
2021-12-13 16:01 ` [PATCH v3 11/11] reftable: make reftable_record a tagged union Han-Wen Nienhuys via GitGitGadget
2021-12-14 11:47 ` [PATCH v4 00/11] Reftable coverity fixes Han-Wen Nienhuys via GitGitGadget
2021-12-14 11:47 ` [PATCH v4 01/11] reftable: fix OOB stack write in print functions Han-Wen Nienhuys via GitGitGadget
2021-12-14 11:47 ` [PATCH v4 02/11] reftable: fix resource leak in block.c error path Han-Wen Nienhuys via GitGitGadget
2021-12-14 11:47 ` [PATCH v4 03/11] reftable: fix resource leak blocksource.c Han-Wen Nienhuys via GitGitGadget
2021-12-14 11:47 ` [PATCH v4 04/11] reftable: check reftable_stack_auto_compact() return value Han-Wen Nienhuys via GitGitGadget
2021-12-14 11:47 ` [PATCH v4 05/11] reftable: ignore remove() return value in stack_test.c Han-Wen Nienhuys via GitGitGadget
2021-12-14 11:47 ` [PATCH v4 06/11] reftable: fix resource warning Han-Wen Nienhuys via GitGitGadget
2021-12-14 11:47 ` [PATCH v4 07/11] reftable: all xxx_free() functions accept NULL arguments Han-Wen Nienhuys via GitGitGadget
2021-12-14 11:47 ` [PATCH v4 08/11] reftable: order unittests by complexity Han-Wen Nienhuys via GitGitGadget
2021-12-14 11:47 ` [PATCH v4 09/11] reftable: drop stray printf in readwrite_test Han-Wen Nienhuys via GitGitGadget
2021-12-14 11:47 ` [PATCH v4 10/11] reftable: handle null refnames in reftable_ref_record_equal Han-Wen Nienhuys via GitGitGadget
2021-12-14 11:47 ` [PATCH v4 11/11] reftable: make reftable_record a tagged union Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 00/16] Reftable coverity fixes Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 01/16] reftable: fix OOB stack write in print functions Han-Wen Nienhuys via GitGitGadget
2021-12-22 22:51 ` Junio C Hamano
2021-12-23 15:58 ` Han-Wen Nienhuys
2021-12-22 18:56 ` [PATCH v5 02/16] reftable: fix resource leak in block.c error path Han-Wen Nienhuys via GitGitGadget
2021-12-22 22:51 ` Junio C Hamano
2021-12-23 17:04 ` Han-Wen Nienhuys
2021-12-24 4:16 ` Junio C Hamano
2022-01-12 11:58 ` Han-Wen Nienhuys
2022-01-12 14:03 ` René Scharfe
2022-01-13 18:52 ` Junio C Hamano
2022-01-13 9:55 ` Ævar Arnfjörð Bjarmason
2022-01-13 14:27 ` Han-Wen Nienhuys
2021-12-22 18:56 ` [PATCH v5 03/16] reftable: fix resource leak blocksource.c Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 04/16] reftable: check reftable_stack_auto_compact() return value Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 05/16] reftable: ignore remove() return value in stack_test.c Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 06/16] reftable: fix resource warning Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 07/16] reftable: all xxx_free() functions accept NULL arguments Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 08/16] reftable: order unittests by complexity Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 09/16] reftable: drop stray printf in readwrite_test Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 10/16] reftable: handle null refnames in reftable_ref_record_equal Han-Wen Nienhuys via GitGitGadget
2021-12-22 22:51 ` Junio C Hamano
2021-12-22 18:56 ` [PATCH v5 11/16] reftable: make reftable-record.h function signatures const correct Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 12/16] reftable: implement record equality generically Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 13/16] reftable: remove outdated file reftable.c Han-Wen Nienhuys via GitGitGadget
2021-12-22 22:51 ` Junio C Hamano
2021-12-24 16:53 ` Ævar Arnfjörð Bjarmason
2021-12-22 18:56 ` [PATCH v5 14/16] reftable: make reftable_record a tagged union Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 15/16] reftable: add print functions to the record types Han-Wen Nienhuys via GitGitGadget
2021-12-22 18:56 ` [PATCH v5 16/16] reftable: be more paranoid about 0-length memcpy calls Han-Wen Nienhuys via GitGitGadget
2021-12-22 22:50 ` Junio C Hamano
2021-12-23 9:49 ` René Scharfe
2021-12-23 18:59 ` Junio C Hamano
2021-12-26 20:51 ` René Scharfe
2021-12-26 21:07 ` Ævar Arnfjörð Bjarmason
2021-12-23 15:58 ` Han-Wen Nienhuys
2021-12-24 4:16 ` Junio C Hamano
2022-01-12 11:39 ` Han-Wen Nienhuys
2022-01-12 12:59 ` Han-Wen Nienhuys
2021-12-22 22:51 ` [PATCH v5 00/16] Reftable coverity fixes Junio C Hamano
2022-01-20 15:11 ` [PATCH v6 00/15] " Han-Wen Nienhuys via GitGitGadget
2022-01-20 15:12 ` [PATCH v6 01/15] reftable: fix OOB stack write in print functions Han-Wen Nienhuys via GitGitGadget
2022-01-21 11:41 ` Ævar Arnfjörð Bjarmason
2022-01-24 14:14 ` Han-Wen Nienhuys
2022-01-20 15:12 ` [PATCH v6 02/15] reftable: fix resource leak in block.c error path Han-Wen Nienhuys via GitGitGadget
2022-01-21 11:42 ` Ævar Arnfjörð Bjarmason
2022-01-22 1:11 ` Junio C Hamano
2022-01-20 15:12 ` [PATCH v6 03/15] reftable: fix resource leak blocksource.c Han-Wen Nienhuys via GitGitGadget
2022-01-20 15:12 ` [PATCH v6 04/15] reftable: check reftable_stack_auto_compact() return value Han-Wen Nienhuys via GitGitGadget
2022-01-21 11:44 ` Ævar Arnfjörð Bjarmason
2022-01-20 15:12 ` [PATCH v6 05/15] reftable: ignore remove() return value in stack_test.c Han-Wen Nienhuys via GitGitGadget
2022-01-21 11:46 ` Ævar Arnfjörð Bjarmason
2022-01-20 15:12 ` [PATCH v6 06/15] reftable: fix resource warning Han-Wen Nienhuys via GitGitGadget
2022-01-20 15:12 ` [PATCH v6 07/15] reftable: all xxx_free() functions accept NULL arguments Han-Wen Nienhuys via GitGitGadget
2022-01-20 15:12 ` [PATCH v6 08/15] reftable: order unittests by complexity Han-Wen Nienhuys via GitGitGadget
2022-01-20 15:12 ` [PATCH v6 09/15] reftable: drop stray printf in readwrite_test Han-Wen Nienhuys via GitGitGadget
2022-01-20 15:12 ` [PATCH v6 10/15] reftable: handle null refnames in reftable_ref_record_equal Han-Wen Nienhuys via GitGitGadget
2022-01-20 15:12 ` [PATCH v6 11/15] reftable: make reftable-record.h function signatures const correct Han-Wen Nienhuys via GitGitGadget
2022-01-20 15:12 ` [PATCH v6 12/15] reftable: implement record equality generically Han-Wen Nienhuys via GitGitGadget
2022-01-21 11:52 ` Ævar Arnfjörð Bjarmason
2022-01-20 15:12 ` [PATCH v6 13/15] reftable: remove outdated file reftable.c Han-Wen Nienhuys via GitGitGadget
2022-01-21 12:05 ` Ævar Arnfjörð Bjarmason
2022-01-20 15:12 ` [PATCH v6 14/15] reftable: make reftable_record a tagged union Han-Wen Nienhuys via GitGitGadget
2022-01-21 12:06 ` Ævar Arnfjörð Bjarmason
2022-01-24 15:34 ` Han-Wen Nienhuys
2022-01-20 15:12 ` [PATCH v6 15/15] reftable: add print functions to the record types Han-Wen Nienhuys via GitGitGadget
2022-01-21 12:33 ` Ævar Arnfjörð Bjarmason
2022-01-24 15:50 ` Han-Wen Nienhuys
2022-01-24 19:13 ` [PATCH v7 00/16] Reftable coverity fixes Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 01/16] reftable: fix OOB stack write in print functions Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:24 ` Ævar Arnfjörð Bjarmason
2022-01-24 19:13 ` [PATCH v7 02/16] reftable: fix resource leak in block.c error path Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 03/16] reftable: fix resource leak blocksource.c Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 04/16] reftable: check reftable_stack_auto_compact() return value Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 05/16] reftable: ignore remove() return value in stack_test.c Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 06/16] reftable: fix resource warning Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 07/16] reftable: all xxx_free() functions accept NULL arguments Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 08/16] reftable: order unittests by complexity Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 09/16] reftable: drop stray printf in readwrite_test Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 10/16] reftable: handle null refnames in reftable_ref_record_equal Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 11/16] reftable: make reftable-record.h function signatures const correct Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 12/16] reftable: implement record equality generically Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 13/16] reftable: remove outdated file reftable.c Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` [PATCH v7 14/16] reftable: make reftable_record a tagged union Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:39 ` Ævar Arnfjörð Bjarmason
2022-01-24 19:53 ` Han-Wen Nienhuys
2022-01-24 21:54 ` Ævar Arnfjörð Bjarmason
2022-02-19 12:54 ` master doesn't compile on xlc 21.01 anymore (old AIX compiler) (was: [PATCH v7 14/16] reftable: make reftable_record a tagged union) Ævar Arnfjörð Bjarmason
2022-02-19 15:11 ` René Scharfe
2022-03-28 19:10 ` [PATCH] reftable: make assignments portable to AIX xlc v12.01 Ævar Arnfjörð Bjarmason
2022-03-28 20:57 ` Junio C Hamano
2022-03-29 12:12 ` Han-Wen Nienhuys
2022-03-29 15:59 ` Junio C Hamano
2022-01-24 19:13 ` [PATCH v7 15/16] reftable: add print functions to the record types Han-Wen Nienhuys via GitGitGadget
2022-01-24 19:13 ` Han-Wen Nienhuys via GitGitGadget [this message]
2022-01-24 19:48 ` [PATCH v7 00/16] Reftable coverity fixes Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556fc11080a67ceda81f6c39fcdd4dc1098ac1b5.1643051624.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=hanwenn@gmail.com \
--cc=l.s.r@web.de \
--cc=nksingh85@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).