From: karthik nayak <karthik.188@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>,
Matthieu Moy <matthieu.moy@grenoble-inp.fr>,
Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH 2/4] ref-filter: add ref-filter API
Date: Fri, 22 May 2015 18:00:22 +0530 [thread overview]
Message-ID: <555F215E.2050607@gmail.com> (raw)
In-Reply-To: <CAPig+cTT+MEUtRJ6=sf5x-q0S2neL=xeNq_gEQAEy4VSRZga7A@mail.gmail.com>
On 05/22/2015 12:10 AM, Eric Sunshine wrote:
> On Thu, May 21, 2015 at 1:30 PM, karthik nayak <karthik.188@gmail.com> wrote:
>> On 05/21/2015 12:37 AM, Eric Sunshine wrote:
>>> On Wed, May 20, 2015 at 9:18 AM, Karthik Nayak <karthik.188@gmail.com>
>>> wrote:
>>>> Makefile | 1 +
>>>> ref-filter.c | 73
>>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>> ref-filter.h | 47 ++++++++++++++++++++++++++++++++++++++
>>>> 3 files changed, 121 insertions(+)
>>>> create mode 100644 ref-filter.c
>>>> create mode 100644 ref-filter.h
>>>
>>> A shortcoming of this approach is that it's not blame-friendly.
>>> Although those of us following this patch series know that much of the
>>> code in this patch was copied from for-each-ref.c, git-blame will not
>>> recognize this unless invoked in the very expensive "git blame -C -C
>>> -C" fashion (if I understand correctly). The most blame-friendly way
>>> to perform this re-organization is to have the code relocation (line
>>> removals and line additions) occur in one patch.
>>>
>>> There are multiple ways you could arrange to do so. One would be to
>>> first have a patch which introduces just a skeleton of the intended
>>> API, with do-nothing function implementations. A subsequent patch
>>> would then relocate the code from for-each-ref.c to ref-filter.c, and
>>> update for-each-ref.c to call into the new (now fleshed-out) API.
>>
>> Did you read Junio's suggestion on how I should re-order this WIP patch
>> series ?
>> That's somewhat on the lines of what you're suggesting. I'll probably be
>> going ahead with that, not really sure about how blame works entirely so
>> what do you think about that?
>
> Yes, Junio's response did a much better job of saying what I intended.
> Also, his response said something I meant to mention but forgot:
> namely that, to ease the review task, code movement should be pure
> movement, and not involve other changes.
>
> Anyhow, follow Junio's advice. He knows what he's talking about. ;-)
>
Alright, Thanks for clearing that out.
Regards,
Karthik
next prev parent reply other threads:[~2015-05-22 12:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 13:14 [WIP] [PATCH 0/4] Unifying git branch -l, git tag -l, and git for-each-ref karthik nayak
2015-05-20 13:18 ` [PATCH 1/4] for-each-ref: rename refinfo members to match similar structures Karthik Nayak
2015-05-20 16:57 ` Matthieu Moy
2015-05-21 6:27 ` karthik nayak
2015-05-20 13:18 ` [PATCH 2/4] ref-filter: add ref-filter API Karthik Nayak
2015-05-20 19:07 ` Eric Sunshine
2015-05-21 17:30 ` karthik nayak
2015-05-21 18:40 ` Eric Sunshine
2015-05-22 12:30 ` karthik nayak [this message]
2015-05-21 8:47 ` Matthieu Moy
2015-05-21 17:22 ` karthik nayak
2015-05-21 17:59 ` karthik nayak
2015-05-22 6:44 ` Matthieu Moy
2015-05-22 12:46 ` karthik nayak
2015-05-23 14:42 ` Matthieu Moy
2015-05-23 16:04 ` Christian Couder
2015-05-23 17:00 ` Matthieu Moy
2015-05-23 17:18 ` Junio C Hamano
2015-05-23 22:33 ` Matthieu Moy
2015-05-23 17:52 ` Karthik Nayak
2015-05-20 13:18 ` [PATCH 3/4] for-each-ref: convert to ref-filter Karthik Nayak
2015-05-20 23:50 ` Junio C Hamano
2015-05-21 6:51 ` karthik nayak
2015-05-20 13:18 ` [PATCH 4/4] ref-filter: move formatting/sorting options from 'for-each-ref' Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555F215E.2050607@gmail.com \
--to=karthik.188@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=matthieu.moy@grenoble-inp.fr \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).