From: Sam Vilain <sam@vilain.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Joey Hess <id@joeyh.name>, GIT Mailing List <git@vger.kernel.org>
Subject: Re: weaning distributions off tarballs: extended verification of git tags
Date: Mon, 02 Mar 2015 12:52:09 -0800 [thread overview]
Message-ID: <54F4CD79.4080209@vilain.net> (raw)
In-Reply-To: <xmqqwq2z9n7c.fsf@gitster.dls.corp.google.com>
On 03/02/2015 12:08 PM, Junio C Hamano wrote:
>> I have a
>> hazy recollection of what it would take to replace SHA-1 in git with
>> something else; it should be possible (though tricky) to do it lazily,
>> where a tree entry has bits (eg, some of the currently unused file
>> mode bits) to denotes which hash algorithm is in use for the entry.
>> However I don't think that got past idea stage...
> I think one reason why it didn't was because it would not work well.
> That "bit that tells this is a new object or old" would mean that a
> single tree can have many different object names, depending on which
> of its component entries are using that bit and which aren't. There
> goes the "we know two trees with the same object name are identical
> without recursing into them" optimization out the window.
>
> Also it would make it impossible to do what you suggest to Joey to
> do, i.e. "exactly the same way that git does", once you start saying
> that a tree object can be encoded in more than one different ways,
> wouldn't it?
I was reasoning that people would rather not have to rewrite their whole
history in order to switch checksum algorithms, and that by allowing
trees to be lazily converted that this would make things more
efficient. However, I think I see your point here that this doesn't work.
However, as a per-commit header, then only first commit which changes
the hashing algorithm would have to re-checksum each of the files: but
just in the current tree, not all the way back to the beginning of
history. The delta logic should not have to care, and these objects
with the same content but different object ID should pack perfectly, so
long as git-pack-objects knows to re-checksum objects with the available
hash algorithms and spot matches.
Other operations like diff which span commit hashing algorithms might be
able to get away with their existing object ranking algorithms and cache
alternate object IDs for content as they operate to facilitate exact
matching across hash algorithm changes.
But actually, for the original problem - just producing a signature with
a different hashing algorithm - probably it would be sufficient to just
re-hash the current commit and the current tree recursively, and the
mixed hash-algorithm case does not need to exist. But I'm just thinking
it might not be too hard to make git nicely generic, to be well prepared
for when a second pre-image attack on SHA-1 becomes practical.
Sam
next prev parent reply other threads:[~2015-03-02 20:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 14:48 weaning distributions off tarballs: extended verification of git tags Colin Walters
2015-02-28 19:14 ` brian m. carlson
2015-02-28 20:34 ` Morten Welinder
2015-03-02 17:09 ` Colin Walters
2015-03-02 18:12 ` Joey Hess
2015-03-02 19:38 ` Sam Vilain
2015-03-02 20:08 ` Junio C Hamano
2015-03-02 20:52 ` Sam Vilain [this message]
2015-03-02 23:20 ` Duy Nguyen
2015-03-02 23:44 ` Junio C Hamano
2015-03-03 0:42 ` Duy Nguyen
2015-03-05 12:36 ` Michael Haggerty
2015-07-08 4:00 ` Colin Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F4CD79.4080209@vilain.net \
--to=sam@vilain.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=id@joeyh.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).