From: Jens Lehmann <Jens.Lehmann@web.de>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>, git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Max Kirillov <max@max630.net>
Subject: Re: [PATCH/RFD 0/3] worktree.* config keys and submodule and multiple worktrees
Date: Sun, 08 Feb 2015 09:41:33 -0800 [thread overview]
Message-ID: <54D79FCD.6060602@web.de> (raw)
In-Reply-To: <54D79EAB.6060301@web.de>
Am 08.02.2015 um 09:36 schrieb Jens Lehmann:
> Am 08.02.2015 um 05:16 schrieb Nguyễn Thái Ngọc Duy:
>> 1/3 is a more complete version of a patch I posted earlier [1]. It
>> makes sure that worktree.* config keys are stored in a different place
>> than $GIT_DIR/config. This allows us to work around the core.worktree
>> issue in multiple worktree setting.
>>
>> I think 1/3 and 2/3 are fine. 3/3 is probably not. It's more of a
>> proof of concept. The tests pass, but there's no migration path for
>> existing submodules. Submodules modified by new Git will confuse old
>> Git because the old ones do not understand worktree.path (the
>> replacement for core.worktree)
>
> Yeah, breaking every submodule cloned with v1.7.9 or newer is not
That's v1.7.8 of course ...
> the way to go. You'd still have to support the old configuration
> name for a very long time.
>
> I wonder if it's worth all the hassle to invent new names. Wouldn't
> it be much better to just keep a list of per-worktree configuration
> value names and use that inside the config code to decide where to
> find them for multiple work trees. That would also work easily for
> stuff like EOL-config and would push the complexity in the config
> machinery and not onto the user.
next prev parent reply other threads:[~2015-02-08 17:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-08 13:16 [PATCH/RFD 0/3] worktree.* config keys and submodule and multiple worktrees Nguyễn Thái Ngọc Duy
2015-02-08 13:16 ` [PATCH 1/3] config.c: new config namespace worktree.* stored in $GIT_DIR/config.worktree Nguyễn Thái Ngọc Duy
2015-02-08 13:16 ` [PATCH 2/3] setup: add worktree.path to shadow core.worktree Nguyễn Thái Ngọc Duy
2015-02-08 13:16 ` [PATCH 3/3] submodule: use worktree.path instead of core.worktree Nguyễn Thái Ngọc Duy
2015-02-08 17:36 ` [PATCH/RFD 0/3] worktree.* config keys and submodule and multiple worktrees Jens Lehmann
2015-02-08 17:41 ` Jens Lehmann [this message]
2015-02-09 9:35 ` Duy Nguyen
2015-03-18 21:33 ` per-repository and per-worktree config variables Max Kirillov
2015-03-24 13:48 ` Duy Nguyen
2015-03-26 12:04 ` [PATCH v2] config.c: split some variables to $GIT_DIR/config.worktree Nguyễn Thái Ngọc Duy
2015-03-26 22:19 ` Max Kirillov
2015-03-29 1:25 ` Duy Nguyen
2015-03-30 21:26 ` Max Kirillov
2015-03-31 12:14 ` [PATCH v3] " Nguyễn Thái Ngọc Duy
2015-03-31 12:17 ` Duy Nguyen
2015-04-01 20:56 ` Max Kirillov
2015-04-03 10:30 ` Duy Nguyen
2015-04-13 23:37 ` Max Kirillov
2015-04-18 11:10 ` Duy Nguyen
2015-04-20 2:51 ` Max Kirillov
2015-04-20 3:22 ` Duy Nguyen
2015-03-25 21:33 ` per-repository and per-worktree config variables Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D79FCD.6060602@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=max@max630.net \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).