From: "Torsten Bögershausen" <tboegi@web.de>
To: "Torsten Bögershausen" <tboegi@web.de>,
"Alfred Perlstein" <alfred@freebsd.org>,
git@vger.kernel.org
Cc: Eric Wong <normalperson@yhbt.net>,
Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
"Michael G. Schwern" <schwern@pobox.com>,
David Fraser <davidf@sjsoft.com>
Subject: Re: [PATCH] git-svn: Support for git-svn propset
Date: Sun, 07 Dec 2014 09:00:12 +0100 [thread overview]
Message-ID: <5484090C.8070101@web.de> (raw)
In-Reply-To: <5483E968.6060708@web.de>
On 2014-12-07 06.45, Torsten Bögershausen wrote:
[]
>> +
>> +test_expect_success 'add multiple props' '
>> + git svn propset svn:keywords "FreeBSD=%H" foo &&
>> + git svn propset fbsd:nokeywords yes foo &&
>> + echo hello >> foo &&
>> + git commit -m "testing propset" foo &&
>> + git svn dcommit
>> + svn_cmd co "$svnrepo" svn_project &&
>> + (cd svn_project && test "`svn propget svn:keywords foo`" = "FreeBSD=%H") &&
>> + (cd svn_project && test "`svn propget fbsd:nokeywords foo`" = "yes") &&
>> + (cd svn_project && test "`svn proplist -q foo | wc -l`" -eq 2) &&
>> + rm -rf svn_project
>> + '
>> +
> Ah, another small thing:
> the "wc -l" will not work under Mac OS X.
> Please see test_line_count() in t/test-lib-functions.sh
>
My excuse:
I think I am wrong here and I need to correct myself after having looked at other TC's.
The "wc -l" should work under Mac OS X.
Another small nit:
This
"`svn propget svn:keywords foo`" = "FreeBSD=%H")
can be written as
"$(svn propget svn:keywords foo)" = "FreeBSD=%H")
(if you want to use the "Git style" for command substitution)
next prev parent reply other threads:[~2014-12-07 8:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 22:29 [PATCH] git-svn: Support for git-svn propset Alfred Perlstein
2014-12-07 5:42 ` Eric Wong
2014-12-07 9:52 ` Alfred Perlstein
2014-12-07 5:45 ` Torsten Bögershausen
2014-12-07 8:00 ` Torsten Bögershausen [this message]
2014-12-07 9:23 ` Eric Sunshine
-- strict thread matches above, loose matches on Subject: below --
2014-12-07 10:47 Alfred Perlstein
2014-12-08 21:36 ` Eric Wong
2014-12-08 23:43 ` Alfred Perlstein
2014-12-01 6:24 Alfred Perlstein
2014-12-01 9:49 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5484090C.8070101@web.de \
--to=tboegi@web.de \
--cc=alfred@freebsd.org \
--cc=davidf@sjsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=normalperson@yhbt.net \
--cc=schwern@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).