From: Johannes Sixt <j6t@kdbg.org>
To: Jonas 'Sortie' Termansen <sortie@maxsi.org>,
Jacob Keller <jacob.e.keller@intel.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Sep 2014, #01; Tue, 2)
Date: Wed, 03 Sep 2014 08:27:59 +0200 [thread overview]
Message-ID: <5406B4EF.3050301@kdbg.org> (raw)
In-Reply-To: <xmqqzjehy8vx.fsf@gitster.dls.corp.google.com>
Am 03.09.2014 00:06, schrieb Junio C Hamano:
> * jt/timer-settime (2014-08-29) 9 commits
> - use timer_settime() for new platforms
> - autoconf: check for timer_settime()
> - autoconf: check for struct itimerspec
> - autoconf: check for struct sigevent
> - autoconf: check for struct timespec
> - autoconf: check for timer_t
> - autoconf: check for setitimer()
> - autoconf: check for struct itimerval
> - git-compat-util.h: add missing semicolon after struct itimerval
>
> Need a rerolled one.
Yes. Please mark the MinGW build as not having timer_settime. Better
yet, implement it in compat/mingw.c to replace its setitimer()
implementation.
As a bug report, currently, I get
CC progress.o
progress.c: In function 'set_progress_signal':
progress.c:66: error: 'CLOCK_MONOTONIC' undeclared (first use in this
function)
even though I have NO_TIMER_SETTIME set in my config.mak (but no other
of new configuration options that this series introduces).
But IMHO, this topic goes in a wrong direction. "Avoid deprecated
interfaces" is way overrated. It would be preferable (IMHO) to implement
setitimer() in compat/ for systems that don't have it.
-- Hannes
next prev parent reply other threads:[~2014-09-03 6:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 22:06 What's cooking in git.git (Sep 2014, #01; Tue, 2) Junio C Hamano
2014-09-03 6:27 ` Johannes Sixt [this message]
2014-09-03 18:45 ` Torsten Bögershausen
2014-09-03 19:18 ` Junio C Hamano
2014-09-03 19:30 ` Keller, Jacob E
2014-09-04 13:46 ` Duy Nguyen
2014-09-04 16:51 ` Junio C Hamano
2014-09-04 17:14 ` Junio C Hamano
2014-09-04 17:25 ` Junio C Hamano
2014-09-05 1:18 ` Duy Nguyen
2014-09-05 0:47 ` Duy Nguyen
2015-03-26 13:46 ` Tommy38
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5406B4EF.3050301@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.e.keller@intel.com \
--cc=sortie@maxsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).