From: "Torsten Bögershausen" <tboegi@web.de>
To: Johannes Sixt <j6t@kdbg.org>, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Stefan Zager" <szager@chromium.org>
Subject: Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)
Date: Sat, 05 Apr 2014 13:56:21 +0200 [thread overview]
Message-ID: <533FEF65.8010108@web.de> (raw)
In-Reply-To: <533FCA92.8060006@kdbg.org>
On 2014-04-05 11.19, Johannes Sixt wrote:
> Am 04.04.2014 22:58, schrieb Junio C Hamano:
>> * sz/mingw-index-pack-threaded (2014-03-19) 1 commit
>> - Enable index-pack threading in msysgit.
>>
>> What is the status of this topic? A failure report exists
>> ($gmane/245170), and I am aware of Duy's $gmane/245034 but that was
>> where the discussion stalled. Is everybody waiting for everybody
>> else to get the discussion unstuck?
>
> I still have to cross-check Duy's patch. I'll hopefully get to it in the
> next days and report back.
>
> -- Hannes
If this helps the discussion:
----------------------------
commit 03d9d2990b718ef6d859405af399f549c186b4df
Merge: 1b8b51b d84a3da
Author: Junio C Hamano <gitster@pobox.com>
Date: Fri Apr 4 13:34:56 2014 -0700
----------------------------
looks like this:
grep "not ok" 5302.txt:
not ok 19 - [index v1] 1) stream pack to repository
not ok 21 - [index v1] 3) corrupted delta happily returned wrong data
not ok 24 - [index v1] 6) newly created pack is BAD !
not ok 25 - [index v2] 1) stream pack to repository
not ok 27 - [index v2] 3) corrupted delta happily returned wrong data
not ok 29 - [index v2] 5) pack-objects refuses to reuse corrupted data
not ok 30 - [index v2] 6) verify-pack detects CRC mismatch
-------------------------------------
After reverting 9d66f2d97a97e08ae8d7c86
t5302 passed 3 times of 4 runs.
In the first run a crashing "dd" was reported, but that
was not reproducable.
(And the test log looked like this:)
--------------------
not ok 20 - [index v1] 2) create a stealth corruption in a delta base reference
# # This test assumes file_101 is a delta smaller than 16 bytes.
# # It should be against file_100 but we substitute its base for file_099
# sha1_101=`git hash-object file_101` &&
# sha1_099=`git hash-object file_099` &&
# offs_101=`index_obj_offset 1.idx $sha1_101` &&
# nr_099=`index_obj_nr 1.idx $sha1_099` &&
# chmod +w ".git/objects/pack/pack-${pack1}.pack" &&
# dd of=".git/objects/pack/pack-${pack1}.pack" seek=$(($offs_101 + 1)) \
# if=".git/objects/pack/pack-${pack1}.idx" \
# skip=$((4 + 256 * 4 + $nr_099 * 24)) \
# bs=1 count=20 conv=notrunc &&
# git cat-file blob $sha1_101 > file_101_foo1
not ok 21 - [index v1] 3) corrupted delta happily returned wrong data
# test -f file_101_foo1 && ! cmp file_101 file_101_foo1
next prev parent reply other threads:[~2014-04-05 11:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 20:58 What's cooking in git.git (Apr 2014, #01; Fri, 4) Junio C Hamano
2014-04-05 9:19 ` Johannes Sixt
2014-04-05 11:56 ` Torsten Bögershausen [this message]
2014-04-07 16:40 ` Junio C Hamano
2014-04-07 18:35 ` Johannes Sixt
2014-04-07 19:42 ` Ramsay Jones
2014-04-08 9:03 ` Torsten Bögershausen
2014-04-08 0:39 ` Duy Nguyen
2014-04-08 13:13 ` Johannes Sixt
2014-04-08 16:26 ` Junio C Hamano
2014-04-06 22:41 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533FEF65.8010108@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=pclouds@gmail.com \
--cc=szager@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).