From: "Kristoffer Haugsbakk" <code@khaugsbakk.name>
To: "Oswald Buddenhagen" <oswald.buddenhagen@gmx.de>
Cc: "Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] sequencer: beautify subject of reverts of reverts
Date: Tue, 28 Mar 2023 15:43:46 +0200 [thread overview]
Message-ID: <5333b921-0be6-49c7-b2dd-7d6ee5700385@app.fastmail.com> (raw)
In-Reply-To: <ZCLqbmWsN/7Ihjg+@ugly>
On Tue, Mar 28, 2023, at 15:23, Oswald Buddenhagen wrote:
> i thought about that already, and concluded that it's getting a bit "too
> nerdy" and over-engineered.
I see that point too.
> the main motivation for me is to break the dogmatism with which some
> people are approaching the matter - "$tool did it, so it is _the_ way".
> set an example where the tool does something "humane", and you may
> change some minds.
Good thinking.
Your patch does something “humane” without adding any involved logic. A
good default for those who don’t want to change the provided revert
message. (Why? I would hope that they at least write something in the
body (after the subject) about why they are (reverting a
revert)/reapplying.)
--
Kristoffer Haugsbakk
Frequent reverter
next prev parent reply other threads:[~2023-03-28 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 16:22 [PATCH] sequencer: beautify subject of reverts of reverts Oswald Buddenhagen
2023-03-25 10:39 ` Kristoffer Haugsbakk
2023-03-27 22:25 ` Junio C Hamano
2023-03-28 6:04 ` Kristoffer Haugsbakk
2023-03-28 13:23 ` Oswald Buddenhagen
2023-03-28 13:43 ` Kristoffer Haugsbakk [this message]
2023-03-28 14:00 ` Junio C Hamano
2023-03-28 14:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5333b921-0be6-49c7-b2dd-7d6ee5700385@app.fastmail.com \
--to=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=oswald.buddenhagen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).