From: Stephan Beyer <s-beyer@gmx.net>
To: Alex Hoffman <spec@gal.ro>, git <git@vger.kernel.org>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
Stefan Beller <sbeller@google.com>
Subject: Re: [PATCH] Correct compile errors when DEBUG_BISECT=1 after supporting other hash algorithms
Date: Wed, 29 Mar 2017 23:36:08 +0200 [thread overview]
Message-ID: <52ac188d-1112-758e-5d02-470afc6ffa8d@gmx.net> (raw)
In-Reply-To: <CAMX8fZXS4k5chezESM4pcaSfhG6WZ4xKxsWB0fpm4h-PQGjXwQ@mail.gmail.com>
Hi,
On 03/29/2017 10:02 PM, Alex Hoffman wrote:
> Any news about this patch?
Haha nice, your initial patch is the same as mine (but mine was part of
a bigger patch series and the v3 is probably going to have one less commit):
https://public-inbox.org/git/1456452282-10325-4-git-send-email-s-beyer@gmx.net/
>> for (pp = commit->parents; pp; pp = pp->next)
>> fprintf(stderr, " %.*s", 8,
>> - sha1_to_hex(pp->item->object.sha1));
>> + oid_to_hex(&pp->item->object.oid));
I guess your change in continued indentation is intentional, but is it
just my mail client or do you f*ck up tabs? (I haven't tried to apply
the patch but it looks like it is not possible due to broken tabs.)
Stephan
prev parent reply other threads:[~2017-03-29 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-19 21:33 [PATCH] Correct compile errors when DEBUG_BISECT=1 after supporting other hash algorithms Alex Hoffman
2017-03-20 18:11 ` Stefan Beller
2017-03-20 22:14 ` brian m. carlson
2017-03-21 21:24 ` Alex Hoffman
2017-03-29 20:02 ` Alex Hoffman
2017-03-29 21:36 ` Stephan Beyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ac188d-1112-758e-5d02-470afc6ffa8d@gmx.net \
--to=s-beyer@gmx.net \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
--cc=sbeller@google.com \
--cc=spec@gal.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).