From: Jens Lehmann <Jens.Lehmann@web.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Anders Kaseorg <andersk@MIT.EDU>
Subject: Re: What's cooking in git.git (Oct 2013, #02; Mon, 14)
Date: Wed, 16 Oct 2013 19:53:30 +0200 [thread overview]
Message-ID: <525ED29A.1020507@web.de> (raw)
In-Reply-To: <20131015200528.GE9464@google.com>
Am 15.10.2013 22:05, schrieb Jonathan Nieder:
> Jens Lehmann wrote:
>> Am 15.10.2013 21:16, schrieb Jonathan Nieder:
>
>>> So I suspect this will fix more scripts than it breaks, though it may
>>> still break some. :/
>>
>> Hmm, I'm really not sure if we should do this or not.
>
> What convinced me was Anders's observation that the current behavior
> can have very bad consequences if a script is passing untrusted input
> in multiple arguments to git submodule foreach.
Ok, that makes sense.
>> And maybe only change that on a major version bump where people should
>> not be terribly surprised about such a change in behavior and are more
>> likely to read release notes?
>
> Ok with me, but please don't make it 2.0. :)
But we don't want to wait for 3.0, no? ;-)
next prev parent reply other threads:[~2013-10-16 17:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 18:45 What's cooking in git.git (Oct 2013, #01; Mon, 14) Jonathan Nieder
2013-10-15 0:12 ` What's cooking in git.git (Oct 2013, #02; " Jonathan Nieder
2013-10-15 5:05 ` Ramkumar Ramachandra
2013-10-15 18:32 ` Junio C Hamano
2013-10-15 19:16 ` Jonathan Nieder
2013-10-15 19:42 ` Jens Lehmann
2013-10-15 20:05 ` Jonathan Nieder
2013-10-16 17:53 ` Jens Lehmann [this message]
2013-10-15 19:45 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525ED29A.1020507@web.de \
--to=jens.lehmann@web.de \
--cc=andersk@MIT.EDU \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).