From: Johannes Sixt <j6t@kdbg.org>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: worldhello.net@gmail.com,
Thomas Braun <thomas.braun@virtuell-zuhause.de>,
Git Mailing List <git@vger.kernel.org>,
msysGit Mailinglist <msysgit@googlegroups.com>
Subject: Re: Same test-path-utils behaves differently on different Windows systems
Date: Thu, 10 Oct 2013 22:04:48 +0200 [thread overview]
Message-ID: <52570860.3060503@kdbg.org> (raw)
In-Reply-To: <CAHGBnuO8ATSQu6HpJTm8bBg0akm+LUsZGRFoZPhzs89q7gTWqQ@mail.gmail.com>
Am 10.10.2013 21:47, schrieb Sebastian Schuberth:
> So the obvious thing would be to replace /a/b/ with
> /foo/bar/ in the tests, but that just masks the problem, or?
The strange behavior is not a problem in Git, it is a problem of MSYS.
Using /foo/bar instead of /a/b in Git's test suite is a reasonable
work-around.
If you mean that you get ../../C:/something from the relative_path
computation, that *is* a problem in Git, which is addressed by the topic
jx/relative-path-regression-fix.
> PS: I'm also quite unhappy about naming the function "mingw_path". The
> path mangling comes from MSYS, not MinGW, so if at all it should be
> named msys_path. But as the code for the "mingw_path" function does
> nothing either MSYS or MinGW related but just prints argv[2] as it was
> passed to main() it should probably simply called "print_path".
You have a point here. If it were to change, "echo_path" would be my
preference.
-- Hannes
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
next prev parent reply other threads:[~2013-10-10 20:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 12:13 Same test-path-utils behaves differently on different Windows systems Sebastian Schuberth
2013-10-10 15:52 ` Sebastian Schuberth
2013-10-10 17:57 ` Johannes Sixt
2013-10-10 19:47 ` Sebastian Schuberth
2013-10-10 20:04 ` Johannes Sixt [this message]
2013-10-10 20:27 ` Sebastian Schuberth
2013-10-10 20:47 ` Sebastian Schuberth
2013-10-15 14:54 ` wwiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52570860.3060503@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=msysgit@googlegroups.com \
--cc=sschuberth@gmail.com \
--cc=thomas.braun@virtuell-zuhause.de \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).