From: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
To: "Torsten Bögershausen" <tboegi@web.de>,
"Alexandr Miloslavskiy via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 2/2] t0028: add more tests
Date: Tue, 24 Sep 2019 12:03:54 +0200 [thread overview]
Message-ID: <5250c693-2d6b-69a1-3ed0-8a3fb3396e30@syntevo.com> (raw)
In-Reply-To: <20190924040637.2hybnk54ehf3uhoa@tb-raspi4>
On 24.09.2019 6:06, Torsten Bögershausen wrote:
> Would this make more sense:
> After I discovered that UTF-16-LE-BOM test was bugged,
> I decided that better tests are required
OK
> Looking at the other test cases, should utf-8 be written as UTF-8
> for consistency ?
OK
> General remark:
> Do we need the {} here?
> ${encoding} could be simpler written as $encoding
> More a style-nit: could we simply write like this:
> printf $expect_bytes > $test_file.raw &&
> test_cmp_bin $test_file.raw $test_file
This is pretty much my first experience with test framework
(and maybe third with shell scripts...). I will change as suggested.
next prev parent reply other threads:[~2019-09-24 10:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 8:33 [PATCH 0/2] t0028 fix test + more tests Alexandr Miloslavskiy via GitGitGadget
2019-09-23 8:33 ` [PATCH 1/2] t0028: fix test for UTF-16-LE-BOM Alexandr Miloslavskiy via GitGitGadget
2019-09-23 8:33 ` [PATCH 2/2] t0028: add more tests Alexandr Miloslavskiy via GitGitGadget
2019-09-23 10:04 ` [PATCH v2 0/2] Update: fixed typos in commit message Alexandr Miloslavskiy via GitGitGadget
2019-09-23 10:04 ` [PATCH v2 2/2] t0028: add more tests Alexandr Miloslavskiy via GitGitGadget
2019-09-24 4:06 ` Torsten Bögershausen
2019-09-24 10:03 ` Alexandr Miloslavskiy [this message]
2019-09-24 6:21 ` Johannes Sixt
2019-09-24 10:31 ` Alexandr Miloslavskiy
2019-09-23 10:04 ` [PATCH v2 1/2] t0028: fix test for UTF-16-LE-BOM Alexandr Miloslavskiy via GitGitGadget
2019-09-24 3:46 ` Torsten Bögershausen
2019-09-24 9:53 ` Alexandr Miloslavskiy
2019-09-24 10:40 ` [PATCH v3 0/2] Update: fixed typos in commit message Alexandr Miloslavskiy via GitGitGadget
2019-09-24 10:40 ` [PATCH v3 1/2] t0028: fix test for UTF-16-LE-BOM Alexandr Miloslavskiy via GitGitGadget
2019-09-24 10:40 ` [PATCH v3 2/2] t0028: add more tests Alexandr Miloslavskiy via GitGitGadget
2019-09-28 4:47 ` Junio C Hamano
2019-09-30 7:26 ` Alexandr Miloslavskiy
2019-09-26 19:37 ` [PATCH v3 0/2] Update: fixed typos in commit message Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5250c693-2d6b-69a1-3ed0-8a3fb3396e30@syntevo.com \
--to=alexandr.miloslavskiy@syntevo.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).