From: Stefan Beller <stefanbeller@googlemail.com>
To: "Koch, Rick (Subcontractor)" <Rick.Koch@tbe.com>
Cc: "'git@vger.kernel.org'" <git@vger.kernel.org>
Subject: Re: CPPCheck found 24 high risk bugs in Git v.1.8.3.4
Date: Mon, 19 Aug 2013 23:36:55 +0200 [thread overview]
Message-ID: <52128FF7.1040909@googlemail.com> (raw)
In-Reply-To: <85C8141E5DAD94428A121F706995A31F010F116FDAD3@MX1.net.tbe.com>
[-- Attachment #1: Type: text/plain, Size: 1505 bytes --]
On 08/19/2013 07:09 PM, Koch, Rick (Subcontractor) wrote:
> I'm directing to this e-mail, as it seems to be the approved forum for posting Git bugs. We ran CPPCheck against Git v.1.8.3.4 and found 24 high risk bugs. Please see the attachment xlsx.
>
> Is there a method to post to the Git community to allow the community to review and debunk as faults positive or develop patches to fix lists code files?
>
Hi,
if you're using cppcheck as found at https://github.com/danmar/cppcheck
or http://sourceforge.net/apps/trac/cppcheck/ you really need to review
the results, as there are many false positives.
I used that tool for my contributions so far (bug fixes as reported by cppcheck).
However you *really* need to manually review any message cppcheck generates.
This is because git is using a C, asm-like coding style for many routines,
whereas that cppcheck is rather optimized to find typical C++ errors.
And the styles vary wildy! (cppcheck tries to become no false positives,
but it's hard I guess)
I am running that cppcheck tool on git regulary (cppcheck master branch on
git master branch), and review for real findings, you're welcome to do so
as well. :)
There are other static code analyzers, which have slightly different
goals, such as http://css.csail.mit.edu/stack/ which has an incredibly
low false positive rate (I found none as of now).
However I think having different tools is a great thing, but you'd need
to know your tools. ;)
Stefan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
prev parent reply other threads:[~2013-08-19 21:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 17:09 CPPCheck found 24 high risk bugs in Git v.1.8.3.4 Koch, Rick (Subcontractor)
2013-08-19 20:03 ` Philip Oakley
2013-08-19 20:40 ` Jeff King
2013-08-19 20:46 ` Junio C Hamano
2013-08-19 20:52 ` Johan Herland
[not found] ` <85C8141E5DAD94428A121F706995A31F010F116FDADE@MX1.net.tbe.com>
2013-08-19 21:46 ` Philip Oakley
2013-08-23 19:51 ` CPPCheck found 24 high risk bugs in Git v.1.8.3.4 (fetch.c L588) Philip Oakley
2013-08-19 22:55 ` CPPCheck found 24 high risk bugs in Git v.1.8.3.4 Philip Oakley
2013-08-19 23:15 ` Erik Faye-Lund
2013-08-20 14:33 ` Jeff King
2013-08-20 18:44 ` Andreas Schwab
2013-08-20 20:34 ` René Scharfe
2013-08-20 22:28 ` Erik Faye-Lund
2013-08-20 22:26 ` Erik Faye-Lund
2013-08-20 23:01 ` Andreas Schwab
2013-08-20 23:45 ` Junio C Hamano
2013-08-21 0:01 ` Erik Faye-Lund
2013-08-19 21:36 ` Stefan Beller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52128FF7.1040909@googlemail.com \
--to=stefanbeller@googlemail.com \
--cc=Rick.Koch@tbe.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).