From: Jens Lehmann <Jens.Lehmann@web.de>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 1/2] submodule: fix confusing variable name
Date: Mon, 19 Aug 2013 23:09:37 +0200 [thread overview]
Message-ID: <52128991.8080603@web.de> (raw)
In-Reply-To: <1376760343-741047-2-git-send-email-sandals@crustytoothpaste.net>
Am 17.08.2013 19:25, schrieb brian m. carlson:
> cmd_summary reads the output of git diff, but reads in the submodule path into a
> variable called name. Since this variable does not contain the name of the
> submodule, but the path, rename it to be clearer what data it actually holds.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Thanks, this one is looking good to me.
Acked-by: Jens Lehmann <Jens.Lehmann@web.de>
> ---
> git-submodule.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 2979197..38520db 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -1032,13 +1032,13 @@ cmd_summary() {
> # Get modified modules cared by user
> modules=$(git $diff_cmd $cached --ignore-submodules=dirty --raw $head -- "$@" |
> sane_egrep '^:([0-7]* )?160000' |
> - while read mod_src mod_dst sha1_src sha1_dst status name
> + while read mod_src mod_dst sha1_src sha1_dst status sm_path
> do
> # Always show modules deleted or type-changed (blob<->module)
> - test $status = D -o $status = T && echo "$name" && continue
> + test $status = D -o $status = T && echo "$sm_path" && continue
> # Also show added or modified modules which are checked out
> - GIT_DIR="$name/.git" git-rev-parse --git-dir >/dev/null 2>&1 &&
> - echo "$name"
> + GIT_DIR="$sm_path/.git" git-rev-parse --git-dir >/dev/null 2>&1 &&
> + echo "$sm_path"
> done
> )
>
>
next prev parent reply other threads:[~2013-08-19 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-17 17:25 [PATCH v2 0/2] Don't print status output with submodule.<name>.ignore=all brian m. carlson
2013-08-17 17:25 ` [PATCH v2 1/2] submodule: fix confusing variable name brian m. carlson
2013-08-19 21:09 ` Jens Lehmann [this message]
2013-08-17 17:25 ` [PATCH v2 2/2] submodule: don't print status output with ignore=all brian m. carlson
2013-08-19 21:14 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52128991.8080603@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).