From: Jeff Hostetler <git@jeffhostetler.com>
To: Junio C Hamano <gitster@pobox.com>, Josh Steadmon <steadmon@google.com>
Cc: git@vger.kernel.org, avarab@gmail.com, peff@peff.net,
Johannes.Schindelin@gmx.de
Subject: Re: [PATCH v2 1/1] trace2: write to directory targets
Date: Thu, 21 Mar 2019 13:43:07 -0400 [thread overview]
Message-ID: <51e88650-8667-df1f-13ef-4537f2e70346@jeffhostetler.com> (raw)
In-Reply-To: <xmqqmulpt22e.fsf@gitster-ct.c.googlers.com>
On 3/20/2019 10:04 PM, Junio C Hamano wrote:
> Josh Steadmon <steadmon@google.com> writes:
>
[...]
>> +/*
>> + * How many attempts we will make at creating a random trace output path.
>> + */
>> +#define MAX_RANDOM_ATTEMPTS 10
>
> With the updated design, randomness is no longer the primary
> property of this new feature. The fact that the names are
> automatically assigned is. It could be that the source of tr2_sid
> may (or may not) be some randomness, but the point is that the
> caller in this patch does not care how tr2_sid is computed.
>
> I'd call this max-attempts (or max-autopath-attempts, but that is
> rather long, and I do not think inside the scope of "tr2_dst" that
> is about "destination", there will be anything but the destination
> path we'd "attempt" with a reasonable maximum value to compute, so
> the "-autopath" clarification would not buy us much)....
>
>> static int tr2_dst_want_warning(void)
>> {
>> static int tr2env_dst_debug = -1;
>> @@ -36,6 +42,53 @@ void tr2_dst_trace_disable(struct tr2_dst *dst)
>> dst->need_close = 0;
>> }
>>
>> +static int tr2_dst_try_random_path(struct tr2_dst *dst, const char *tgt_prefix)
>
> .... and I'd call this s/random/auto/ instead, if I were writing
> this patch following the updated design.
I agree with Junio WRT the s/random/auto/ suggestions.
[...]
>> + for (attempt_count = 0; attempt_count < MAX_RANDOM_ATTEMPTS; attempt_count++) {
>> + strbuf_reset(&final_path);
>> + strbuf_addbuf(&final_path, &base_path);
>> + strbuf_addf(&final_path, ".%d", attempt_count);
Since the last component of the SID is already very unique and
we're unlikely to have collisions, maybe change the above line to:
if (attempt_count > 0)
strbuf_addf(&final_path, ".%d", attempt_count);
and in reality expect to never have files with the suffix.
Unless, that is, they turned on more than one of GIT_TR2,
GIT_TR2_PERF, or GIT_TR2_EVENT and pointed them at the same
directory, but I'm not sure if I care about that edge case
or not.
>> + fd = open(final_path.buf, O_WRONLY | O_CREAT | O_EXCL, 0666);
[...]
Nice. Thanks for looking into this.
Jeff
next prev parent reply other threads:[~2019-03-21 17:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 23:33 [PATCH 0/2] Randomize / timestamp trace2 targets Josh Steadmon
2019-03-13 23:33 ` [PATCH 1/2] date: make get_time() public Josh Steadmon
2019-03-13 23:33 ` [PATCH 2/2] trace2: randomize/timestamp trace2 targets Josh Steadmon
2019-03-13 23:49 ` Ævar Arnfjörð Bjarmason
2019-03-15 18:39 ` Jeff Hostetler
2019-03-15 19:26 ` Ævar Arnfjörð Bjarmason
2019-03-15 20:14 ` Jeff Hostetler
2019-03-15 20:43 ` Josh Steadmon
2019-03-15 20:49 ` Josh Steadmon
2019-03-18 1:40 ` Junio C Hamano
2019-03-19 3:17 ` Jeff King
2019-03-14 0:16 ` Jeff King
2019-03-14 6:07 ` Junio C Hamano
2019-03-14 14:34 ` [PATCH 0/2] Randomize / timestamp " Johannes Schindelin
2019-03-15 20:37 ` Josh Steadmon
2019-03-15 19:18 ` Jeff Hostetler
2019-03-15 20:38 ` Josh Steadmon
2019-03-18 12:50 ` Jeff Hostetler
2019-03-21 0:16 ` [PATCH v2 0/1] Write trace2 output to directories Josh Steadmon
2019-03-21 0:16 ` [PATCH v2 1/1] trace2: write to directory targets Josh Steadmon
2019-03-21 2:04 ` Junio C Hamano
2019-03-21 17:43 ` Jeff Hostetler [this message]
2019-03-22 3:30 ` Junio C Hamano
2019-03-22 14:20 ` Jeff Hostetler
2019-03-21 21:09 ` [PATCH v3 0/1] Write trace2 output to directories Josh Steadmon
2019-03-21 21:09 ` [PATCH v3 1/1] trace2: write to directory targets Josh Steadmon
2019-03-23 20:44 ` Ævar Arnfjörð Bjarmason
2019-03-24 12:33 ` Junio C Hamano
2019-03-24 14:51 ` Ævar Arnfjörð Bjarmason
2019-03-25 2:21 ` Junio C Hamano
2019-03-25 8:21 ` Ævar Arnfjörð Bjarmason
2019-03-25 16:29 ` Jeff Hostetler
2019-03-21 21:16 ` [PATCH v3 0/1] Write trace2 output to directories Jeff Hostetler
2019-03-22 5:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51e88650-8667-df1f-13ef-4537f2e70346@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).