From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Mantas Mikulėnas" <grawity@gmail.com>
Subject: Re: [PATCH] do_one_ref(): save and restore value of current_ref
Date: Wed, 24 Jul 2013 07:35:24 -0700 [thread overview]
Message-ID: <51EFE62C.4070003@alum.mit.edu> (raw)
In-Reply-To: <7vppueuyw4.fsf@alter.siamese.dyndns.org>
On 07/19/2013 12:34 PM, Junio C Hamano wrote:
> Michael Haggerty <mhagger@alum.mit.edu> writes:
>
>> I sent the patch shortly before leaving for a trip so I didn't have time
>> to make it as complete as I would have liked. But given that the
>> problem was already in master, and the fix is pretty simple, I wanted to
>> send the fix right away. When I have some time I can fix it up better,
>
> That is very much appreciated. How would you describe this fix in a
> two-to-three line paragraph in Release Notes?
How about:
Fix a NULL-pointer dereference during nested iterations over
references (for example, when replace references are being used).
Unfortunately I don't have time now to audit the code more carefully to
figure out what other circumstances might have triggered the bug.
Hope that helps,
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
prev parent reply other threads:[~2013-07-24 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-13 13:27 Segfault in `git describe` Mantas Mikulėnas
2013-07-15 13:03 ` Michael Haggerty
2013-07-15 13:31 ` Mantas Mikulėnas
2013-07-15 15:24 ` [PATCH] do_one_ref(): save and restore value of current_ref Michael Haggerty
2013-07-18 4:03 ` Junio C Hamano
2013-07-19 17:43 ` Michael Haggerty
2013-07-19 19:34 ` Junio C Hamano
2013-07-24 14:35 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EFE62C.4070003@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=grawity@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).