From: Stefan Beller <stefanbeller@googlemail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: sunshine@sunshineco.com, git@vger.kernel.org
Subject: Re: [PATCH] mailmap: Testing the single letter name case.
Date: Sat, 13 Jul 2013 20:14:20 +0200 [thread overview]
Message-ID: <51E198FC.5080005@googlemail.com> (raw)
In-Reply-To: <7v8v1aicn5.fsf@alter.siamese.dyndns.org>
On 07/13/2013 07:38 PM, Junio C Hamano wrote:
> Stefan Beller <stefanbeller@googlemail.com> writes:
>
>> This is a regression test for a66e77eab70a08938fdc2227b7ada0f0465c6991
>
> Sorry, I do not quite get this.
>
> If you apply the patch on top of the said commit before that commit, the
> new test does not pass.
>
> But if you apply the patch on top of the said commit, the new test
> still does not pass.
>
> So I am having hard time guessing what you meant by "regression
> test". It is not "a66e77 broke something that ought to work, and
> this shows the breakage". It is not "a66e77 fixed something and
> this shows the previous breakage that got fixed."
>
> It may be because the test is depending on ShortName not to be
> downcased incorrectly, which was to be fixed by a later commit. But
> after applying this on top of jc/mailmap-case-insensitivity topic,
> the test does not pass (and reverting a66e77 does not seem to affect
> the result, either).
>
I am sorry for the bad wording, sorry for wasting your time.
This patch was meant to replace 134d1ac9be2ce97c60a7e9187c32980681811cb5
(current test, latest commit on mailmap-case-insensitivity)
Indeed the patch tests for both bugs unintentionally.
So both the one letter name is being used and the email
case sensitivity is checked.
So maybe I should redo it again and make 2 explicit test cases
for each of the fixes?
Stefan
next prev parent reply other threads:[~2013-07-13 18:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 21:38 [PATCH 0/4] Microfixes to mailmap Junio C Hamano
2013-07-12 21:38 ` [PATCH 1/4] mailmap: do not lose single-letter names Junio C Hamano
2013-07-13 7:20 ` [PATCH] mailmap: Testing the single letter name case Stefan Beller
2013-07-13 17:38 ` Junio C Hamano
2013-07-13 18:14 ` Stefan Beller [this message]
2013-07-13 20:20 ` Junio C Hamano
2013-07-15 2:31 ` Eric Sunshine
2013-07-15 15:54 ` Junio C Hamano
2013-07-14 2:38 ` Eric Sunshine
2013-07-12 21:38 ` [PATCH 2/4] mailmap: do not downcase mailmap entries Junio C Hamano
2013-07-12 21:38 ` [PATCH 3/4] mailmap: style fixes Junio C Hamano
2013-07-12 21:38 ` [PATCH 4/4] add a testcase for checking case insensitivity of mailmap Junio C Hamano
2013-07-12 22:38 ` Eric Sunshine
2013-07-12 22:51 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E198FC.5080005@googlemail.com \
--to=stefanbeller@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).