From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Michael Haggerty <mhagger@alum.mit.edu>,
Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
Johannes Sixt <j6t@kdbg.org>,
"Shawn O. Pearce" <spearce@spearce.org>,
mlevedahl@gmail.com, dpotapov@gmail.com,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [RFC/PATCH 0/1] cygwin: Remove the Win32 l/stat() functions
Date: Thu, 11 Jul 2013 18:31:54 +0100 [thread overview]
Message-ID: <51DEEC0A.9060001@ramsay1.demon.co.uk> (raw)
In-Reply-To: <51DBEDAF.30708@web.de>
Torsten Bögershausen wrote:
> On 30.06.13 19:28, Ramsay Jones wrote:
[ ... ]
>>> You have just described my second patch! :D
>> Unfortunately, I have not had any time to work on the patch this weekend.
>> However, despite the patch being a bit rough around the edges, I decided
>> to send it out (see below) to get some early feedback.
>>
>> Note that it passes the t3210, t3211, t5500, t3200, t3301, t7606 and t1301
>> tests, but I have not run the full test suite.
>>
>> Comments welcome.
>>
>> ATB,
>> Ramsay Jones
>>
>> -- >8 --
>> Subject: [PATCH] cygwin: Add fast_[l]stat() functions
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
>> ---
>> builtin/apply.c | 6 +++---
>> builtin/commit.c | 2 +-
>> builtin/ls-files.c | 2 +-
>> builtin/rm.c | 2 +-
>> builtin/update-index.c | 2 +-
>> check-racy.c | 2 +-
>> compat/cygwin.c | 12 ------------
>> compat/cygwin.h | 10 +++-------
>> diff-lib.c | 2 +-
>> diff.c | 2 +-
>> entry.c | 4 ++--
>> git-compat-util.h | 13 +++++++++++--
>> help.c | 5 +----
>> path.c | 9 +--------
>> preload-index.c | 2 +-
>> read-cache.c | 6 +++---
>> unpack-trees.c | 8 ++++----
>> 17 files changed, 36 insertions(+), 53 deletions(-)
>>
[ ... ]
> I managed to apply your patch on next, and run the test suite before and after
> your patch.
> The performance running "git status" on a linux kernel is the same as in v1.8.3.
>
> Running test suite did not show new failures.
> The following test cases had failed, and are fixed now:
> < t1400-update-ref
> < t3210-pack-refs
> < t3211-peel-ref
> < t3306-notes-prune
> < t5304-prune
> < t5404-tracking-branches
> < t5500-fetch-pack
> < t5505-remote
> < t5514-fetch-multiple
> < t5515-fetch-merge-logic
> < t6030-bisect-porcelain
> < t9300-fast-import
> < t9903-bash-prompt
>
> In short: Thanks, This looks good to me.
Thank you for testing this! It is much appreciated.
I sent a v2 patch to the list last night. It passes the full
test suite for me on cygwin 1.5, although there appears to be
a slight performance problem on MinGW (perhaps!). :(
ATB,
Ramsay Jones
next prev parent reply other threads:[~2013-07-11 17:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51C5FD28.1070004@ramsay1.demon.co.uk>
[not found] ` <51C7A875.6020205@gmail.com>
[not found] ` <7va9mf6txq.fsf@alter.siamese.dyndns.org>
2013-06-25 19:23 ` [RFC/PATCH 0/1] cygwin: Remove the Win32 l/stat() functions Johannes Sixt
2013-06-25 20:23 ` Torsten Bögershausen
2013-06-25 21:18 ` Junio C Hamano
2013-06-26 14:19 ` Torsten Bögershausen
2013-06-26 21:54 ` Ramsay Jones
2013-06-27 15:19 ` Torsten Bögershausen
2013-06-27 23:18 ` Ramsay Jones
2013-06-27 2:37 ` Mark Levedahl
[not found] ` <51C6BC4B.9030905@web.de>
[not found] ` <51C8BF2C.2050203@ramsay1.demon.co.uk>
[not found] ` <7vy59y4w3r.fsf@alter.siamese.dyndns.org>
2013-06-26 21:39 ` Ramsay Jones
[not found] ` <51C94425.7050006@alum.mit.edu>
2013-06-26 21:45 ` Ramsay Jones
2013-06-26 22:35 ` Jeff King
2013-06-26 22:43 ` Jeff King
2013-06-27 22:58 ` Ramsay Jones
2013-06-28 2:31 ` Mark Levedahl
2013-06-27 5:51 ` Michael Haggerty
2013-06-27 19:58 ` Jeff King
2013-06-27 21:04 ` Junio C Hamano
2013-06-27 23:09 ` Ramsay Jones
2013-06-30 17:28 ` Ramsay Jones
2013-06-30 19:50 ` Junio C Hamano
2013-07-04 18:18 ` Ramsay Jones
2013-07-09 11:02 ` Torsten Bögershausen
2013-07-11 17:31 ` Ramsay Jones [this message]
2013-06-27 22:17 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DEEC0A.9060001@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=mhagger@alum.mit.edu \
--cc=mlevedahl@gmail.com \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).