From: "Torsten Bögershausen" <tboegi@web.de>
To: Thomas Rast <trast@inf.ethz.ch>
Cc: git@vger.kernel.org, "Torsten Bögershausen" <tboegi@web.de>
Subject: Re: [PATCH 2/2] test-lint: detect 'export FOO=bar'
Date: Mon, 08 Jul 2013 21:31:37 +0200 [thread overview]
Message-ID: <51DB1399.9020307@web.de> (raw)
In-Reply-To: <24ee18d3b06883c4185821f5ffb5faed26e6a436.1373296313.git.trast@inf.ethz.ch>
On 2013-07-08 17.20, Thomas Rast wrote:
> Some shells do not understand the one-line construct, and instead need
>
> FOO=bar &&
> export FOO
>
> Detect this in the test-lint target.
>
> Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
> ---
>
> I wrote:
>
>> Torsten Bögershausen <tboegi@web.de> writes:
> [...]
>>> - export HARNESS_ACTIVE=t &&
>>> + HARNESS_ACTIVE=t &&
>>> + export HARNESS_ACTIVE &&
> [...]
>> Ack. Sorry for breaking this -- I suppose test-lint would have caught
>> me out?
>
> Well, no, not yet.
Thanks for working on this
>
>
> t/check-non-portable-shell.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
> index 8b5a71d..45971f4 100755
> --- a/t/check-non-portable-shell.pl
> +++ b/t/check-non-portable-shell.pl
> @@ -21,6 +21,7 @@ while (<>) {
> /^\s*declare\s+/ and err 'arrays/declare not portable';
> /^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
> /test\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
> + /^\s*export\s+[^=]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)';
I have a slightly tighter reg exp in my tree, but credits should go to Thomas:
/^\s*export\s+\S+=\S+/
/Torsten
next prev parent reply other threads:[~2013-07-08 19:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 9:21 [PATCH] t0000: do not use export X=Y Torsten Bögershausen
2013-07-08 14:36 ` Thomas Rast
2013-07-08 15:20 ` [PATCH 1/2] t9902: fix 'test A == B' to use = operator Thomas Rast
2013-07-08 15:20 ` [PATCH 2/2] test-lint: detect 'export FOO=bar' Thomas Rast
2013-07-08 19:31 ` Torsten Bögershausen [this message]
2013-07-09 9:28 ` Thomas Rast
2013-07-09 9:53 ` Torsten Bögershausen
2013-07-08 17:20 ` [PATCH 1/2] t9902: fix 'test A == B' to use = operator Junio C Hamano
2013-07-09 9:27 ` Thomas Rast
2013-07-08 15:20 ` [PATCH] t0000: do not use export X=Y Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DB1399.9020307@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).