From: Michael Haggerty <mhagger@alum.mit.edu> To: benoit.person@ensimag.fr Cc: git@vger.kernel.org, Celestin Matte <celestin.matte@ensimag.fr>, Matthieu Moy <matthieu.moy@grenoble-inp.fr>, Junio C Hamano <gitster@pobox.com> Subject: Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable Date: Wed, 03 Jul 2013 12:30:49 +0200 [thread overview] Message-ID: <51D3FD59.7090701@alum.mit.edu> (raw) In-Reply-To: <1372804789-12732-3-git-send-email-benoit.person@ensimag.fr> On 07/03/2013 12:39 AM, benoit.person@ensimag.fr wrote: > From: Benoit Person <benoit.person@ensimag.fr> > > For now, bin-wrappers (based on wrap-for-bin.sh) redefine some > environnement variables (like $GITPERLLIB). If we want to chain to > those scripts and define one of those variables before, our changes > will be overwritten. > > This patch simply makes the bin-wrappers prepend their modifications > rather than redefine the vars. Your commit message makes it sound like GITPERLLIB is only one example of a general class of environment variables fixed by the patch, but in fact the patch address *only* GITPERLLIB. Please make the commit message better match the patch. And maybe you could mention for posterity whether you have seen other variables that will need fixing vs. you did an audit and think that GITPERLLIB is the only problematic one vs. you haven't looked for other similar problems at all. This could save some time for the next person with a similar itch and/or maybe inspire somebody to do an audit. Thanks, Michael > Signed-off-by: Benoit Person <benoit.person@ensimag.fr> > Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr> > --- > wrap-for-bin.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/wrap-for-bin.sh b/wrap-for-bin.sh > index 53a8dd0..dbebe49 100644 > --- a/wrap-for-bin.sh > +++ b/wrap-for-bin.sh > @@ -14,7 +14,7 @@ else > GIT_TEMPLATE_DIR='@@BUILD_DIR@@/templates/blt' > export GIT_TEMPLATE_DIR > fi > -GITPERLLIB='@@BUILD_DIR@@/perl/blib/lib' > +GITPERLLIB='@@BUILD_DIR@@/perl/blib/lib:'"$GITPERLLIB" > GIT_TEXTDOMAINDIR='@@BUILD_DIR@@/po/build/locale' > PATH='@@BUILD_DIR@@/bin-wrappers:'"$PATH" > export GIT_EXEC_PATH GITPERLLIB PATH GIT_TEXTDOMAINDIR > -- Michael Haggerty mhagger@alum.mit.edu http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2013-07-03 10:30 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-02 22:39 [PATCH v7 0/7] git-remote-mediawiki: new tool to preview local changes without pushing benoit.person 2013-07-02 22:39 ` [PATCH v7 1/7] git-remote-mediawiki: Introduction of Git::Mediawiki.pm benoit.person 2013-07-02 22:59 ` Junio C Hamano 2013-07-02 22:39 ` [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable benoit.person 2013-07-02 23:01 ` Junio C Hamano 2013-07-02 23:19 ` Benoît Person 2013-07-03 8:54 ` Junio C Hamano 2013-07-03 9:46 ` Benoît Person 2013-07-03 10:30 ` Michael Haggerty [this message] 2013-07-03 10:57 ` Matthieu Moy 2013-07-03 20:24 ` Junio C Hamano 2013-07-03 20:38 ` Matthieu Moy 2013-07-03 21:50 ` Junio C Hamano 2013-07-02 22:39 ` [PATCH v7 3/7] git-remote-mediawiki: New git bin-wrapper for developement benoit.person 2013-07-02 23:04 ` Junio C Hamano 2013-07-02 22:39 ` [PATCH v7 4/7] git-remote-mediawiki: Update tests to run with the new bin-wrapper benoit.person 2013-07-03 9:18 ` Matthieu Moy 2013-07-02 22:39 ` [PATCH v7 5/7] git-remote-mediawiki: Factoring code between git-remote-mediawiki and Git::Mediawiki benoit.person 2013-07-02 22:39 ` [PATCH v7 6/7] git-remote-mediawiki: Adding git-mw command benoit.person 2013-07-02 22:39 ` [PATCH v7 7/7] git-remote-mediawiki: Add preview subcommand into git mw benoit.person
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51D3FD59.7090701@alum.mit.edu \ --to=mhagger@alum.mit.edu \ --cc=benoit.person@ensimag.fr \ --cc=celestin.matte@ensimag.fr \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=matthieu.moy@grenoble-inp.fr \ --subject='Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).