From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
"Mark Levedahl" <mlevedahl@gmail.com>,
ramsay@ramsay1.demon.co.uk, git@vger.kernel.org
Subject: Re: [PATCH] CYGWIN: Use a TCP socket for pipe()
Date: Tue, 02 Jul 2013 16:57:21 +0200 [thread overview]
Message-ID: <51D2EA51.5000807@web.de> (raw)
In-Reply-To: <7vwqpbi4ws.fsf@alter.siamese.dyndns.org>
On 2013-07-01 00.56, Junio C Hamano wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> I testet "rj/cygwin-remove-cheating-lstat" with the "socket pipe" on top:
>> no hanging.
>>
>> Then I run "rj/cygwin-remove-cheating-lstat" without "socket pipe",
>> (or in other words git.git/pu):
>> No hanging.
>
> So an immediate conclusion is that we can forget about this patch?
Yes
>
>> So at the moment I don't have any problems to report for cygwin, which is good.
>>
>> And it looks as if "rj/cygwin-remove-cheating-lstat" prevents the "hanging",
>> so there is another +1 to keep it and move it into next.
>
> Ramsay started a "mark places we call lstat() when we do not really
> need fully correct lstat" topic, and I think it may be a sane
> direction to go, as long as the helper function's semantic is
> clearly defined.
>
> It would be worth seeing where it leads us, before ripping that
> "cheating and incomplete lstat out, I think.
I currently run the test suite on it, based on next.
Got one hanging, but of a different kind:
git was running fetch, but the corresponding git-upload-pack.exe was not in the
task list of the windows explorer, but it was in ps under cygwin.
diff --git a/run-command.c b/run-command.c
index aece872..ee588eb 100644
--- a/run-command.c
+++ b/run-command.c
@@ -226,6 +226,9 @@ static inline void set_cloexec(int fd)
fcntl(fd, F_SETFD, flags | FD_CLOEXEC);
}
+#if defined(__CYGWIN__)
+#define wait_or_whine(p, a) (p)
+#else
static int wait_or_whine(pid_t pid, const char *argv0)
{
int status, code = -1;
@@ -268,6 +271,7 @@ static int wait_or_whine(pid_t pid, const char *argv0)
errno = failed_errno;
return code;
}
+#endif
(And I needed to remove the credential helper tests)
More info later
/Torsten
prev parent reply other threads:[~2013-07-02 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 16:31 [PATCH] CYGWIN: Use a TCP socket for pipe() Torsten Bögershausen
2013-06-27 17:38 ` Junio C Hamano
2013-06-28 2:46 ` Mark Levedahl
2013-06-30 19:47 ` Torsten Bögershausen
2013-06-30 22:56 ` Junio C Hamano
2013-07-02 14:57 ` Torsten Bögershausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D2EA51.5000807@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mlevedahl@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).