From: Mark Levedahl <mlevedahl@gmail.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Junio C Hamano <gitster@pobox.com>, Johannes Sixt <j6t@kdbg.org>,
dpotapov@gmail.com, Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
mhagger@alum.mit.edu, Jeff King <peff@peff.net>,
"Shawn O. Pearce" <spearce@spearce.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFC/PATCH 0/1] cygwin: Remove the Win32 l/stat() functions
Date: Wed, 26 Jun 2013 22:37:06 -0400 [thread overview]
Message-ID: <51CBA552.80309@gmail.com> (raw)
In-Reply-To: <51CAF863.4020803@web.de>
On 06/26/2013 10:19 AM, Torsten Bögershausen wrote:
> On 2013-06-25 23.18, Junio C Hamano wrote:
>> Johannes Sixt <j6t@kdbg.org> writes:
>>
>>> Some context: This is about a patch by Ramsay that removes the
>>> "schizophrenic lstat" hack for Cygwin. Junio, can you please queue that
>>> patch in pu?
>> Sure. Thanks.
> First of all,
> thanks for the work.
>
> Here some "benchmark" results,
> (The test run of the test suite did the same amout of time).
>
> But:
> git status -uno in real life takes double the time,
> git 1.8.3 compared against "pu with the vanilla l/stat"
>
> 1 second -> 2 seconds on linux kernel
> 0.2 seconds -> 0.4 seconds on git.git
>
> Do we have any known problems with the current implementation ?
> Does speed matter ?
>
> One vote to keep the special cygwin functions.
> (And have a look how to improve the core.filemode)
>
> /Torsten
>
>
There have been threads on the cygwin mailing lists for at least a
decade looking to speed up cygwin's posix stat / lstat (and fork). If
improvement were merely difficult, it would have been done long ago. As
git cares about things like execute bits, file / repository permissions,
and soft links, whatever stat / lstat git uses needs to fully support
those under cygwin, either by using what cygwin provides or providing a
complete replacement. Note my other reply - with Ramsay's patch I can
complete the test suite (except for t0008.sh that has a known hang)
while without it I find the test suite randomly (unrepeatable) hangs in
many tests. So, this stat/lstat replacement is at least implicated in
current troubles.
Mark
next prev parent reply other threads:[~2013-06-27 2:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51C5FD28.1070004@ramsay1.demon.co.uk>
[not found] ` <51C7A875.6020205@gmail.com>
[not found] ` <7va9mf6txq.fsf@alter.siamese.dyndns.org>
2013-06-25 19:23 ` [RFC/PATCH 0/1] cygwin: Remove the Win32 l/stat() functions Johannes Sixt
2013-06-25 20:23 ` Torsten Bögershausen
2013-06-25 21:18 ` Junio C Hamano
2013-06-26 14:19 ` Torsten Bögershausen
2013-06-26 21:54 ` Ramsay Jones
2013-06-27 15:19 ` Torsten Bögershausen
2013-06-27 23:18 ` Ramsay Jones
2013-06-27 2:37 ` Mark Levedahl [this message]
[not found] ` <51C6BC4B.9030905@web.de>
[not found] ` <51C8BF2C.2050203@ramsay1.demon.co.uk>
[not found] ` <7vy59y4w3r.fsf@alter.siamese.dyndns.org>
2013-06-26 21:39 ` Ramsay Jones
[not found] ` <51C94425.7050006@alum.mit.edu>
2013-06-26 21:45 ` Ramsay Jones
2013-06-26 22:35 ` Jeff King
2013-06-26 22:43 ` Jeff King
2013-06-27 22:58 ` Ramsay Jones
2013-06-28 2:31 ` Mark Levedahl
2013-06-27 5:51 ` Michael Haggerty
2013-06-27 19:58 ` Jeff King
2013-06-27 21:04 ` Junio C Hamano
2013-06-27 23:09 ` Ramsay Jones
2013-06-30 17:28 ` Ramsay Jones
2013-06-30 19:50 ` Junio C Hamano
2013-07-04 18:18 ` Ramsay Jones
2013-07-09 11:02 ` Torsten Bögershausen
2013-07-11 17:31 ` Ramsay Jones
2013-06-27 22:17 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CBA552.80309@gmail.com \
--to=mlevedahl@gmail.com \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=spearce@spearce.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).